[balsa] address-book-config: Do not crash
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa] address-book-config: Do not crash
- Date: Wed, 18 Sep 2019 15:54:24 +0000 (UTC)
commit 524026268f919b924fb3781a60735be341e8ab5f
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Wed Sep 18 11:51:15 2019 -0400
address-book-config: Do not crash
* src/address-book-config.c (edit_book_response): destroy the
dialog as the last step; otherwise the struct is freed before we
use it.
ChangeLog | 8 ++++++++
src/address-book-config.c | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
---
diff --git a/ChangeLog b/ChangeLog
index 75f955365..ed5a8ad98 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2019-09-18 Peter Bloomfield <pbloomfield bellsouth net>
+
+ address-book-config: Do not crash
+
+ * src/address-book-config.c (edit_book_response): destroy the
+ dialog as the last step; otherwise the struct is freed before we
+ use it.
+
2019-08-25 Peter Bloomfield <pbloomfield bellsouth net>
* src/balsa-print-object-text.c
diff --git a/src/address-book-config.c b/src/address-book-config.c
index 9546d34f5..e481b947b 100644
--- a/src/address-book-config.c
+++ b/src/address-book-config.c
@@ -163,9 +163,10 @@ edit_book_response(GtkWidget * dialog, gint response,
break;
}
- gtk_widget_destroy(dialog);
if (abc->address_book)
g_object_set_data(G_OBJECT(abc->address_book), "balsa-abc", NULL);
+
+ gtk_widget_destroy(dialog);
}
/* Radio buttons */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]