[gnome-control-center] info-overview: Drop unused data from panel class.
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] info-overview: Drop unused data from panel class.
- Date: Wed, 25 Sep 2019 13:57:21 +0000 (UTC)
commit 85da3bc062e0257c21528f31cd78733146f3d9e6
Author: Robert Ancell <robert ancell canonical com>
Date: Wed Sep 25 22:46:29 2019 +1200
info-overview: Drop unused data from panel class.
The variables are stored in the panel but only used once. Two of them are never
used.
panels/info-overview/cc-info-overview-panel.c | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
---
diff --git a/panels/info-overview/cc-info-overview-panel.c b/panels/info-overview/cc-info-overview-panel.c
index 8ae9c8efa..8cfe56dd3 100644
--- a/panels/info-overview/cc-info-overview-panel.c
+++ b/panels/info-overview/cc-info-overview-panel.c
@@ -70,10 +70,6 @@ typedef struct
GtkWidget *virt_type_title_label;
GtkWidget *updates_button;
- char *gnome_version;
- char *gnome_distributor;
- char *gnome_date;
-
GCancellable *cancellable;
UDisksClient *client;
@@ -613,7 +609,7 @@ info_overview_panel_setup_virt (CcInfoOverviewPanel *self)
static void
info_overview_panel_setup_overview (CcInfoOverviewPanel *self)
{
- gboolean res;
+ g_autofree gchar *gnome_version = NULL;
glibtop_mem mem;
const glibtop_sysinfo *info;
g_autofree char *memory_text = NULL;
@@ -622,13 +618,10 @@ info_overview_panel_setup_overview (CcInfoOverviewPanel *self)
g_autofree char *os_name_text = NULL;
CcInfoOverviewPanelPrivate *priv = cc_info_overview_panel_get_instance_private (self);
- res = load_gnome_version (&priv->gnome_version,
- &priv->gnome_distributor,
- &priv->gnome_date);
- if (res)
+ if (load_gnome_version (&gnome_version, NULL, NULL))
{
g_autofree gchar *text = NULL;
- text = g_strdup_printf (_("Version %s"), priv->gnome_version);
+ text = g_strdup_printf (_("Version %s"), gnome_version);
gtk_label_set_text (GTK_LABEL (priv->version_label), text);
}
@@ -709,10 +702,6 @@ cc_info_overview_panel_finalize (GObject *object)
g_clear_object (&priv->client);
- g_free (priv->gnome_version);
- g_free (priv->gnome_date);
- g_free (priv->gnome_distributor);
-
G_OBJECT_CLASS (cc_info_overview_panel_parent_class)->finalize (object);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]