[orca] Don't announce returning to browse mode when page is loading
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [orca] Don't announce returning to browse mode when page is loading
- Date: Fri, 10 Apr 2020 22:17:27 +0000 (UTC)
commit a954934126530fd522e7f6c26726da5e458a3c83
Author: Joanmarie Diggs <jdiggs igalia com>
Date: Fri Apr 10 18:09:50 2020 -0400
Don't announce returning to browse mode when page is loading
Often we get focus events when a page is loading that can cause us to
switch to browse mode. This can be followed by another event which
causes us to immediately switch back to focus mode. Hearing Orca say
"browse mode focus mode" is not especially useful.
We'll continue to announce switching to focus mode even when a page is
loading because certain web apps emit focus events for widgets while
the page is still loading.
src/orca/scripts/web/script.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/src/orca/scripts/web/script.py b/src/orca/scripts/web/script.py
index c25d9e7bb..39d58b478 100644
--- a/src/orca/scripts/web/script.py
+++ b/src/orca/scripts/web/script.py
@@ -1177,8 +1177,8 @@ class Script(default.Script):
self.utilities.setCaretContext(obj.parent, -1)
elif parentRole == pyatspi.ROLE_MENU:
self.utilities.setCaretContext(obj.parent.parent, -1)
-
- self.presentMessage(messages.MODE_BROWSE)
+ if not self._loadingDocumentContent:
+ self.presentMessage(messages.MODE_BROWSE)
else:
if not self.utilities.grabFocusWhenSettingCaret(obj) \
and (self._lastCommandWasCaretNav \
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]