[geary/mjog/logging-improvements: 2/23] Geary.Logging.Source: Clean and fix up property modifiers



commit 36327e532852c26f48d5b35d9c7e810fcd7b7c74
Author: Michael Gratton <mike vee net>
Date:   Wed Apr 15 14:56:54 2020 +1000

    Geary.Logging.Source: Clean and fix up property modifiers

 src/engine/api/geary-client-service.vala | 8 +++++++-
 src/engine/util/util-logging.vala        | 2 +-
 2 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/src/engine/api/geary-client-service.vala b/src/engine/api/geary-client-service.vala
index b5bee4fc..175e105d 100644
--- a/src/engine/api/geary-client-service.vala
+++ b/src/engine/api/geary-client-service.vala
@@ -198,10 +198,16 @@ public abstract class Geary.ClientService : BaseObject, Logging.Source {
     public ErrorContext? last_error { get; private set; default = null; }
 
     /** {@inheritDoc} */
-    public Logging.Flag logging_flags {
+    public override Logging.Flag logging_flags {
         get; protected set; default = Logging.Flag.ALL;
     }
 
+    /** {@inheritDoc} */
+    // XXX see GNOME/vala#119 for why this is necessary
+    public virtual string logging_domain {
+        get { return Logging.DOMAIN; }
+    }
+
     /** {@inheritDoc} */
     public Logging.Source? logging_parent { get { return _logging_parent; } }
     private weak Logging.Source? _logging_parent = null;
diff --git a/src/engine/util/util-logging.vala b/src/engine/util/util-logging.vala
index 78286a68..9afa8cc8 100644
--- a/src/engine/util/util-logging.vala
+++ b/src/engine/util/util-logging.vala
@@ -158,7 +158,7 @@ public interface Geary.Logging.Source : GLib.Object {
      * this interface can call that method if they need to override
      * the default behaviour of this method.
      */
-    public string to_string() {
+    public virtual string to_string() {
         return Source.default_to_string(this, "");
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]