[gtk/wip/baedert/for-master: 37/39] text: unconditionally unref attr list



commit 1886648652f272497e83c1fb3a775ad3dce782f1
Author: Timm Bäder <mail baedert org>
Date:   Fri Apr 17 07:27:21 2020 +0200

    text: unconditionally unref attr list
    
    pango_attr_list_unref() works on NULL

 gtk/gtktext.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/gtk/gtktext.c b/gtk/gtktext.c
index 8091b2fb46..77ddeb488b 100644
--- a/gtk/gtktext.c
+++ b/gtk/gtktext.c
@@ -4335,7 +4335,7 @@ gtk_text_create_layout (GtkText  *self,
   GtkTextPrivate *priv = gtk_text_get_instance_private (self);
   GtkWidget *widget = GTK_WIDGET (self);
   PangoLayout *layout;
-  PangoAttrList *tmp_attrs;
+  PangoAttrList *tmp_attrs = NULL;
   char *preedit_string = NULL;
   int preedit_length = 0;
   PangoAttrList *preedit_attrs = NULL;
@@ -4419,9 +4419,7 @@ gtk_text_create_layout (GtkText  *self,
   g_free (preedit_string);
   g_free (display_text);
 
-  if (preedit_attrs)
-    pango_attr_list_unref (preedit_attrs);
-
+  pango_attr_list_unref (preedit_attrs);
   pango_attr_list_unref (tmp_attrs);
 
   return layout;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]