[nautilus/wip/antoniof/local_vs_native_fixup: 146/157] files-view: Drop unnecessary precondition check
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus/wip/antoniof/local_vs_native_fixup: 146/157] files-view: Drop unnecessary precondition check
- Date: Mon, 14 Dec 2020 19:00:49 +0000 (UTC)
commit af7d6ed44069f4fed8d3058bd6968c99749ea5fa
Author: António Fernandes <antoniof gnome org>
Date: Wed May 13 00:52:28 2020 +0100
files-view: Drop unnecessary precondition check
When creating a file from template, we fail if the template's not local
This was introduced by commit e5e83363ca306025ccbf328ed7bf782fda58eb81
The assumption of being local comes from the original version of that
patch[1], which used filenames instead of URIs, as later explained[2]:
> I was sure that templates will be only stored on the local disk,
> ignoring that we have to pass URIs to GnomeVFS anyway.
As a result of the review process, the usage of filenames was dropped
in favor of URIs, but the precondition check remained, even though it
was no longer necessary.
Remove it now.
[1] https://mail.gnome.org/archives/nautilus-list/2005-June/msg00008.html
[2] https://mail.gnome.org/archives/nautilus-list/2005-June/msg00176.html
src/nautilus-files-view.c | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index 678ad98b6..cd46cbf95 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -2443,8 +2443,6 @@ nautilus_files_view_new_file (NautilusFilesView *directory_view,
return;
}
- g_return_if_fail (nautilus_file_is_local (source));
-
data = setup_new_folder_data (directory_view);
source_uri = nautilus_file_get_uri (source);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]