[libgdamm] Column: Remove get/set_attribute()
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libgdamm] Column: Remove get/set_attribute()
- Date: Sun, 19 Jan 2020 15:00:41 +0000 (UTC)
commit 33a538afe44ef1e12ec9436f854bcc2a6c8d6f5f
Author: Murray Cumming <murraycu google com>
Date: Sun Jan 12 15:56:09 2020 +0100
Column: Remove get/set_attribute()
They were removed from libgda.
libgda/src/column.ccg | 15 ---------------
libgda/src/column.hg | 20 ++------------------
2 files changed, 2 insertions(+), 33 deletions(-)
---
diff --git a/libgda/src/column.ccg b/libgda/src/column.ccg
index 4b16f5c..4ed4217 100644
--- a/libgda/src/column.ccg
+++ b/libgda/src/column.ccg
@@ -46,21 +46,6 @@ bool Column::equal(const Glib::RefPtr<const Column>& src) const
return result;
}
-
-static void on_set_attribute_destroy(gpointer data)
-{
- g_free((char*)data);
-}
-
-void Column::set_attribute(const Glib::ustring& attribute, const Value& value)
-{
- //gda_column_set_attribute() has stupid memory management.
- //See http://bugzilla.gnome.org/show_bug.cgi?id=564402
- gchar* dup = g_strdup(attribute.c_str());
- gda_column_set_attribute(gobj(), dup, (value).gobj(), &on_set_attribute_destroy);
-}
-
-
} // namespace Gda
} // namespace Gnome
diff --git a/libgda/src/column.hg b/libgda/src/column.hg
index cb288d3..c091901 100644
--- a/libgda/src/column.hg
+++ b/libgda/src/column.hg
@@ -1,9 +1,7 @@
/* $Id: column.hg,v 1.14 2006/11/30 06:58:55 murrayc Exp $ */
// -*- C++ -*- //
-/* modelcolumnattributes.h
- *
- * Copyright 2003 libgdamm Development Team
+/* Copyright 2003 libgdamm Development Team
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
@@ -33,17 +31,6 @@ namespace Gnome
namespace Gda
{
-
-/* possible predefined attribute names for gda_holder_get_attribute() or gda_column_get_attribute() */
-// Keep in sync with libgda
-// TODO: How/When/Why are these used? Where are they documented? murrayc.
-const std::string ATTRIBUTE_DESCRIPTION = "__gda_attr_descr"; /* G_TYPE_STRING */
-const std::string ATTRIBUTE_NAME = "__gda_attr_name"; /* G_TYPE_STRING */
-const std::string ATTRIBUTE_NUMERIC_PRECISION = "__gda_attr_numeric_precision"; /* G_TYPE_INT */
-const std::string ATTRIBUTE_NUMERIC_SCALE = "__gda_attr_numeric_scale"; /* G_TYPE_INT */
-const std::string ATTRIBUTE_AUTO_INCREMENT = "__gda_attr_autoinc"; /* G_TYPE_BOOLEAN */
-const std::string ATTRIBUTE_IS_DEFAULT = "__gda_attr_is_default"; /* G_TYPE_BOOLEAN */
-
/** Management of DataModel column attributes.
*
* @ingroup DataHandlers
@@ -63,10 +50,7 @@ public:
_WRAP_METHOD(Glib::ustring get_description() const, gda_column_get_description)
_WRAP_METHOD(void set_description(const Glib::ustring& title), gda_column_set_description)
- _IGNORE(gda_column_set_attribute)
- void set_attribute(const Glib::ustring& attribute, const Value& value);
- _WRAP_METHOD(Value get_attribute(const Glib::ustring& attribute) const, gda_column_get_attribute)
-
+
_WRAP_METHOD(Glib::ustring get_name() const, gda_column_get_name)
_WRAP_METHOD(void set_name(const Glib::ustring& name), gda_column_set_name)
_WRAP_METHOD(Glib::ustring get_dbms_type() const, gda_column_get_dbms_type)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]