[gnome-shell] dialog: Split out _setLabel function



commit 012dde3de966e62772b171362a2eb29102ff2fb2
Author: Jonas Dreßler <verdre v0yd nl>
Date:   Sun Jan 19 23:20:02 2020 +0100

    dialog: Split out _setLabel function
    
    This will be useful when adding more generic containers like
    MessageDialogContent.
    
    https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/935

 js/ui/dialog.js | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
---
diff --git a/js/ui/dialog.js b/js/ui/dialog.js
index dfa656230f..642873be65 100644
--- a/js/ui/dialog.js
+++ b/js/ui/dialog.js
@@ -3,6 +3,13 @@
 
 const { Clutter, GObject, Pango, St } = imports.gi;
 
+function _setLabel(label, value) {
+    label.set({
+        text: value || '',
+        visible: value !== null,
+    });
+}
+
 var Dialog = GObject.registerClass(
 class Dialog extends St.Widget {
     _init(parentActor, styleClass) {
@@ -185,18 +192,12 @@ var MessageDialogContent = GObject.registerClass({
     }
 
     set title(title) {
-        this._setLabel(this._title, 'title', title);
+        _setLabel(this._title, title);
+        this.notify('title');
     }
 
     set description(description) {
-        this._setLabel(this._description, 'description', description);
-    }
-
-    _setLabel(label, prop, value) {
-        label.set({
-            text: value || '',
-            visible: value != null,
-        });
-        this.notify(prop);
+        _setLabel(this._description, description);
+        this.notify('description');
     }
 });


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]