[orca] Don't call saveFocusedObjectInfo() in setCaretPosition()



commit 716d2b9e099e2e2cea2a94f1f8ab5f26ce277fec
Author: Joanmarie Diggs <joanmarie diggs gmail com>
Date:   Tue Jan 21 18:34:26 2020 -0500

    Don't call saveFocusedObjectInfo() in setCaretPosition()
    
    When we update our position via caret navigation and then present the
    new location, we lose state information that we need, such as the cell
    coordinates we used to be in. This can cause us to think the row hasn't
    changed when, in fact, it has.
    
    We're already saving state in locusOfFocusChanged(). That should be the
    only place we do it.

 src/orca/scripts/web/script_utilities.py | 3 ---
 1 file changed, 3 deletions(-)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 1e4024e6d..34306dd38 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -449,9 +449,6 @@ class Utilities(script_utilities.Utilities):
         if obj:
             obj.clearCache()
 
-        # TODO - JD: This is private.
-        self._script._saveFocusedObjectInfo(obj)
-
     def getNextObjectInDocument(self, obj, documentFrame):
         if not obj:
             return None


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]