[gnome-shell/uajain/adapt-user-avatar-part2: 97/105] authPrompt: Move cancel button, entry and spinner to a single row
- From: Umang Jain <uajain src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/uajain/adapt-user-avatar-part2: 97/105] authPrompt: Move cancel button, entry and spinner to a single row
- Date: Fri, 31 Jan 2020 16:18:38 +0000 (UTC)
commit 53c023a8ee4330110b0d60cb24fd39317d798de7
Author: Umang Jain <mailumangjain gmail com>
Date: Wed Jan 15 00:32:24 2020 +0530
authPrompt: Move cancel button, entry and spinner to a single row
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/922
.../gnome-shell-sass/widgets/_login-dialog.scss | 7 +-
js/gdm/authPrompt.js | 85 ++++++++++------------
2 files changed, 46 insertions(+), 46 deletions(-)
---
diff --git a/data/theme/gnome-shell-sass/widgets/_login-dialog.scss
b/data/theme/gnome-shell-sass/widgets/_login-dialog.scss
index 536f635bec..ebeabafc21 100644
--- a/data/theme/gnome-shell-sass/widgets/_login-dialog.scss
+++ b/data/theme/gnome-shell-sass/widgets/_login-dialog.scss
@@ -72,7 +72,7 @@
.login-dialog-logo-bin { padding: 24px 0px; }
.login-dialog-banner { color: darken($osd_fg_color,10%); }
-.login-dialog-button-box { spacing: 5px; }
+.login-dialog-button-box { width: 23em; spacing: 5px; }
.login-dialog-message-warning { color: $warning_color; }
.login-dialog-message-hint { padding-top: 0; padding-bottom: 20px; }
.login-dialog-user-selection-box { padding: 100px 0px; }
@@ -141,6 +141,11 @@
width: 23em;
}
+.login-dialog-prompt-entry {
+ width: 262px;
+ height: 24px;
+}
+
.login-dialog-prompt-label {
color: darken($osd_fg_color, 20%);
@include fontsize($base_font_size + 1);
diff --git a/js/gdm/authPrompt.js b/js/gdm/authPrompt.js
index be40a67708..6d289a226e 100644
--- a/js/gdm/authPrompt.js
+++ b/js/gdm/authPrompt.js
@@ -101,28 +101,7 @@ var AuthPrompt = GObject.registerClass({
this.add_child(this._label);
- let entryParams = {
- style_class: 'login-dialog-prompt-entry',
- can_focus: true,
- x_expand: false,
- y_expand: true,
- };
-
- this._entry = null;
-
- this._textEntry = new St.Entry(entryParams);
- ShellEntry.addContextMenu(this._textEntry, { actionMode: Shell.ActionMode.NONE });
-
- this._passwordEntry = new St.PasswordEntry(entryParams);
- ShellEntry.addContextMenu(this._passwordEntry, { actionMode: Shell.ActionMode.NONE });
-
- this._entry = this._passwordEntry;
- this.add_child(this._entry);
-
- this._entry.grab_key_focus();
-
- this._capsLockWarningLabel = new ShellEntry.CapsLockWarning();
- this.add_child(this._capsLockWarningLabel);
+ this._initEntryRow();
this._message = new St.Label({
opacity: 0,
@@ -134,26 +113,6 @@ var AuthPrompt = GObject.registerClass({
this._message.clutter_text.line_wrap = true;
this._message.clutter_text.ellipsize = Pango.EllipsizeMode.NONE;
this.add_child(this._message);
-
- this._buttonBox = new St.BoxLayout({
- style_class: 'login-dialog-button-box',
- vertical: false,
- y_align: Clutter.ActorAlign.END,
- });
- this.add_child(this._buttonBox);
-
- this._defaultButtonWell = new St.Widget({
- layout_manager: new Clutter.BinLayout(),
- x_align: Clutter.ActorAlign.END,
- y_align: Clutter.ActorAlign.CENTER,
- });
-
- this._initButtons();
-
- this._spinner = new Animation.Spinner(DEFAULT_BUTTON_WELL_ICON_SIZE);
- this._spinner.opacity = 0;
- this._spinner.show();
- this._defaultButtonWell.add_child(this._spinner);
}
_onDestroy() {
@@ -167,7 +126,13 @@ var AuthPrompt = GObject.registerClass({
return Clutter.EVENT_PROPAGATE;
}
- _initButtons() {
+ _initEntryRow() {
+ let mainBox = new St.BoxLayout({
+ style_class: 'login-dialog-button-box',
+ vertical: false,
+ });
+ this.add_child(mainBox);
+
this.cancelButton = new St.Button({
style_class: 'modal-dialog-button button',
button_mask: St.ButtonMask.ONE | St.ButtonMask.THREE,
@@ -179,9 +144,24 @@ var AuthPrompt = GObject.registerClass({
y_align: Clutter.ActorAlign.END,
});
this.cancelButton.connect('clicked', () => this.cancel());
- this._buttonBox.add_child(this.cancelButton);
+ mainBox.add_child(this.cancelButton);
+
+ let entryParams = {
+ style_class: 'login-dialog-prompt-entry',
+ can_focus: true,
+ };
- this._buttonBox.add_child(this._defaultButtonWell);
+ this._entry = null;
+
+ this._textEntry = new St.Entry(entryParams);
+ ShellEntry.addContextMenu(this._textEntry, { actionMode: Shell.ActionMode.NONE });
+
+ this._passwordEntry = new St.PasswordEntry(entryParams);
+ ShellEntry.addContextMenu(this._passwordEntry, { actionMode: Shell.ActionMode.NONE });
+
+ this._entry = this._passwordEntry;
+ mainBox.add_child(this._entry);
+ this._entry.grab_key_focus();
this._entry.clutter_text.connect('text-changed', () => {
if (!this._userVerifier.hasPendingMessages)
@@ -189,6 +169,21 @@ var AuthPrompt = GObject.registerClass({
});
this._entry.clutter_text.connect('activate', () => this.emit('next'));
+
+ this._capsLockWarningLabel = new ShellEntry.CapsLockWarning();
+ this.add_child(this._capsLockWarningLabel);
+
+ this._defaultButtonWell = new St.Widget({
+ layout_manager: new Clutter.BinLayout(),
+ x_align: Clutter.ActorAlign.END,
+ y_align: Clutter.ActorAlign.CENTER,
+ });
+ mainBox.add_child(this._defaultButtonWell);
+
+ this._spinner = new Animation.Spinner(DEFAULT_BUTTON_WELL_ICON_SIZE);
+ this._spinner.opacity = 0;
+ this._spinner.show();
+ this._defaultButtonWell.add_child(this._spinner);
}
_updateEntry(secret) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]