[b458944d9ec4322f9ff0de2885ce82d580341fcf0fd688422e9929b6e7ce3b2d] Add --explicit-exit-notify by default when --proto udp
- From: Thomas Haller <thaller src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [b458944d9ec4322f9ff0de2885ce82d580341fcf0fd688422e9929b6e7ce3b2d] Add --explicit-exit-notify by default when --proto udp
- Date: Wed, 8 Jul 2020 08:58:20 +0000 (UTC)
commit 483a04288b2b79e523901c85fba8b82379a323d2
Author: Katelyn Schiesser <katelyn schiesser gmail com>
Date: Tue Jul 7 21:17:21 2020 -0700
Add --explicit-exit-notify by default when --proto udp
When using UDP, there is no transport-protocol method to notify the server
that the client has disconnected. For TCP, the socket closing signals the
server to close the peer instance; for UDP, the server must wait for a
configured --ping-exit, --keepalive, or similar to free up the connection.
https://gitlab.gnome.org/GNOME/NetworkManager-openvpn/-/merge_requests/24
src/nm-openvpn-service.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/src/nm-openvpn-service.c b/src/nm-openvpn-service.c
index 1e86014..27ff30e 100644
--- a/src/nm-openvpn-service.c
+++ b/src/nm-openvpn-service.c
@@ -1439,8 +1439,10 @@ nm_openvpn_start_openvpn_binary (NMOpenvpnPlugin *plugin,
}
} else if (nm_streq0 (proto_tcp, "yes"))
args_add_strv (args, "tcp-client");
- else
+ else {
args_add_strv (args, "udp");
+ args_add_strv (args, "--explicit-exit-notify");
+ }
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]