[gdm/wip/kill-x-on-login-too-plz: 213/214] local-display-factory: kill X on login just like wayland



commit d35805116113acbf1e112962c54785c604b13181
Author: Ray Strode <rstrode redhat com>
Date:   Thu Oct 11 07:15:56 2018 -0400

    local-display-factory: kill X on login just like wayland
    
    These days we kill the wayland login screen during login to
    conserve system resources.
    
    We've been reluctant to do the same for X based login screens,
    because X didn't handle being killed in the background so well.
    
    This is no longer a problem, since this commit:
    
    https://gitlab.freedesktop.org/xorg/xserver/-/commit/ff91c696ff8f5f56da40e107cb5c321539758a81
    
    So let's go ahead and kill it now.

 daemon/gdm-local-display-factory.c | 9 ---------
 1 file changed, 9 deletions(-)
---
diff --git a/daemon/gdm-local-display-factory.c b/daemon/gdm-local-display-factory.c
index 8709edd0..4a1889e7 100644
--- a/daemon/gdm-local-display-factory.c
+++ b/daemon/gdm-local-display-factory.c
@@ -668,7 +668,6 @@ static void
 maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
                                   GdmDisplay             *display)
 {
-        g_autofree char *display_session_type = NULL;
         gboolean doing_initial_setup = FALSE;
 
         if (gdm_display_get_status (display) != GDM_DISPLAY_MANAGED) {
@@ -677,7 +676,6 @@ maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
         }
 
         g_object_get (G_OBJECT (display),
-                      "session-type", &display_session_type,
                       "doing-initial-setup", &doing_initial_setup,
                       NULL);
 
@@ -687,13 +685,6 @@ maybe_stop_greeter_in_background (GdmLocalDisplayFactory *factory,
                 return;
         }
 
-        /* we can only stop greeter for wayland sessions, since
-         * X server would jump back on exit */
-        if (g_strcmp0 (display_session_type, "wayland") != 0) {
-                g_debug ("GdmLocalDisplayFactory: login window is running on Xorg, so ignoring");
-                return;
-        }
-
         g_debug ("GdmLocalDisplayFactory: killing login window once its unused");
 
         g_object_set (G_OBJECT (display), "status", GDM_DISPLAY_WAITING_TO_FINISH, NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]