[gnome-shell] windowManager: Warn when removing old animationInfo
- From: Robert Mader <rmader src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] windowManager: Warn when removing old animationInfo
- Date: Mon, 15 Jun 2020 13:21:07 +0000 (UTC)
commit c23ad83c593880c09efcc733cf1ff6dd9453d187
Author: Jonas Dreßler <verdre v0yd nl>
Date: Tue May 12 12:28:03 2020 +0200
windowManager: Warn when removing old animationInfo
Now that we properly notify mutter about when a size-change animation
has ended, it should never happen that a new size-change animation is
started without the last one being cancelled (ie. 'kill-window-effects'
being emitted).
This means there should also never be an old animationInfo attached to a
window actor, so warn in case we still find one when starting the
animation.
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1251
js/ui/windowManager.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/windowManager.js b/js/ui/windowManager.js
index 97601eee47..1ea5daff70 100644
--- a/js/ui/windowManager.js
+++ b/js/ui/windowManager.js
@@ -1301,8 +1301,10 @@ var WindowManager = class {
actor.freeze();
- if (this._clearAnimationInfo(actor))
+ if (this._clearAnimationInfo(actor)) {
+ log('Old animationInfo removed from actor %s'.format(actor));
this._shellwm.completed_size_change(actor);
+ }
let destroyId = actor.connect('destroy', () => {
this._clearAnimationInfo(actor);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]