[gjs/ewlsh/update-eslint] Update dangling comma preferences. - We don't want dangling commas on functions.
- From: Evan Welsh <ewlsh src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs/ewlsh/update-eslint] Update dangling comma preferences. - We don't want dangling commas on functions.
- Date: Tue, 23 Jun 2020 00:21:34 +0000 (UTC)
commit f2e72927c4f8b64734c493a3218507ffc98882b4
Author: Evan Welsh <noreply evanwelsh com>
Date: Mon Jun 22 19:20:55 2020 -0500
Update dangling comma preferences.
- We don't want dangling commas on functions.
.eslintrc.yml | 4 +++-
examples/gtk-application.js | 6 +++---
2 files changed, 6 insertions(+), 4 deletions(-)
---
diff --git a/.eslintrc.yml b/.eslintrc.yml
index 3fa6b86b..7bcb5eb0 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -24,7 +24,9 @@ rules:
# allow: [^vfunc_, ^on_, _instance_init]
comma-dangle:
- error
- - always-multiline
+ - arrays: always-multiline
+ objects: always-multiline
+ functions: never
comma-spacing:
- error
- before: false
diff --git a/examples/gtk-application.js b/examples/gtk-application.js
index 514b8bdd..e8ea05a4 100644
--- a/examples/gtk-application.js
+++ b/examples/gtk-application.js
@@ -20,7 +20,7 @@ var ExampleApplication = GObject.registerClass({
'ExampleProperty', // nickname
'An example read write property', // description
GObject.ParamFlags.READWRITE, // read/write/construct...
- 'a default value',
+ 'a default value'
),
},
Signals: {'examplesig': {param_types: [GObject.TYPE_INT]}},
@@ -83,7 +83,7 @@ var ExampleApplication = GObject.registerClass({
notif.set_title('Example Notification');
notif.set_body('Example Body');
notif.set_icon(
- new Gio.ThemedIcon({name: 'dialog-information-symbolic'}),
+ new Gio.ThemedIcon({name: 'dialog-information-symbolic'})
);
// A default action for when the body of the notification is clicked
@@ -92,7 +92,7 @@ var ExampleApplication = GObject.registerClass({
// A button for the notification
notif.add_button(
'Button Text',
- "app.exampleAction('exampleParameter')",
+ "app.exampleAction('exampleParameter')"
);
// This won't actually be shown, since an application needs a .desktop
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]