[gtk/wip/otte/for-master: 9/10] build: Add more useful warning flags
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/wip/otte/for-master: 9/10] build: Add more useful warning flags
- Date: Thu, 5 Mar 2020 06:07:53 +0000 (UTC)
commit 7d45ce89ab7d0b1245c9def60cdf45e2442ca64a
Author: Benjamin Otte <otte redhat com>
Date: Thu Mar 5 03:58:29 2020 +0100
build: Add more useful warning flags
I found those on the interwebs and decided they are useful.
gdk/gdkrgbaprivate.h | 2 +-
meson.build | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/gdk/gdkrgbaprivate.h b/gdk/gdkrgbaprivate.h
index 5126f57355..fc355f5913 100644
--- a/gdk/gdkrgbaprivate.h
+++ b/gdk/gdkrgbaprivate.h
@@ -28,7 +28,7 @@
((c) >= 'a' && (c) <= 'f') ? ((c)-'a'+10) : \
((c) >= '0' && (c) <= '9') ? ((c)-'0') : \
-1))
-#define _GDK_RGBA_SELECT_COLOR(_str, index3, index6) _GDK_RGBA_DECODE (sizeof(_str) <= 4 ? (_str)[index3] :
(_str)[index6])
+#define _GDK_RGBA_SELECT_COLOR(_str, index3, index6) (sizeof(_str) <= 4 ? _GDK_RGBA_DECODE ((_str)[index3])
: _GDK_RGBA_DECODE ((_str)[index6]))
#define GDK_RGBA(str) ((GdkRGBA) {\
((_GDK_RGBA_SELECT_COLOR(str, 0, 0) << 4) | _GDK_RGBA_SELECT_COLOR(str, 0, 1)) / 255., \
((_GDK_RGBA_SELECT_COLOR(str, 1, 2) << 4) | _GDK_RGBA_SELECT_COLOR(str, 1, 3)) / 255., \
diff --git a/meson.build b/meson.build
index 2ba1516d7e..dea88448b7 100644
--- a/meson.build
+++ b/meson.build
@@ -238,12 +238,15 @@ elif cc.get_id() == 'gcc' or cc.get_id() == 'clang'
test_cflags = [
'-fno-strict-aliasing',
'-Wcast-align',
+ '-Wduplicated-branches',
+ '-Wduplicated-cond',
'-Wformat=2',
'-Wformat-nonliteral',
'-Wformat-security',
'-Wignored-qualifiers',
'-Wimplicit-function-declaration',
'-Wlogical-op',
+ '-Wmisleading-indentation',
'-Wmissing-format-attribute',
'-Wmissing-include-dirs',
'-Wmissing-noreturn',
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]