[gnome-shell] slider: Include handle border radius when calculating center offset



commit 3ddae9d8151718eeda283823d5440550e61e7612
Author: Jonas Dreßler <verdre v0yd nl>
Date:   Sun Mar 1 14:01:14 2020 +0100

    slider: Include handle border radius when calculating center offset
    
    Since 38da479ee we correctly ceil the non-integer radius of the slider
    handle when calculating the offset for drawing the circle. Since the
    handle also has a border with a width of 1px by default, we should also
    factor that in when calculating the offset.
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/1569

 js/ui/slider.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/slider.js b/js/ui/slider.js
index 01b29e1fc2..3a732e9cf4 100644
--- a/js/ui/slider.js
+++ b/js/ui/slider.js
@@ -43,10 +43,10 @@ var Slider = GObject.registerClass({
         let [hasHandleColor, handleBorderColor] =
             themeNode.lookup_color('-slider-handle-border-color', false);
 
-        let wholeHandleRadius = Math.ceil(handleRadius);
-        let handleX = wholeHandleRadius +
-            (width - 2 * wholeHandleRadius) * this._value / this._maxValue;
-        let handleY = height / 2;
+        const ceiledHandleRadius = Math.ceil(handleRadius + handleBorderWidth);
+        const handleX = ceiledHandleRadius +
+            (width - 2 * ceiledHandleRadius) * this._value / this._maxValue;
+        const handleY = height / 2;
 
         let color = themeNode.get_foreground_color();
         Clutter.cairo_set_source_color(cr, color);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]