[gnome-games/wip/exalm/runner-refactor: 8/56] retro-runner: Create display in construct block
- From: Alexander Mikhaylenko <alexm src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-games/wip/exalm/runner-refactor: 8/56] retro-runner: Create display in construct block
- Date: Sat, 7 Mar 2020 12:41:20 +0000 (UTC)
commit cea4d74af84f190f4dfe65b0cb06c0a08cada0cd
Author: Alexander Mikhaylenko <alexm gnome org>
Date: Fri Mar 6 00:37:52 2020 +0500
retro-runner: Create display in construct block
src/retro/retro-runner.vala | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
---
diff --git a/src/retro/retro-runner.vala b/src/retro/retro-runner.vala
index d88478d3..b80437d2 100644
--- a/src/retro/retro-runner.vala
+++ b/src/retro/retro-runner.vala
@@ -95,6 +95,10 @@ public class Games.RetroRunner : Object, Runner {
is_ready = false;
settings = new Settings ("org.gnome.Games");
+ view = new Retro.CoreView ();
+
+ settings.changed["video-filter"].connect (on_video_filter_changed);
+ on_video_filter_changed ();
}
~RetroRunner () {
@@ -147,13 +151,7 @@ public class Games.RetroRunner : Object, Runner {
if (game_savestates.length != 0)
latest_savestate = game_savestates[0];
- // Step 2) Init the CoreView -------------------------------------------
- // This is done here such that get_display() won't return null
- view = new Retro.CoreView ();
- settings.changed["video-filter"].connect (on_video_filter_changed);
- on_video_filter_changed ();
-
- // Step 3) Instantiate the core
+ // Step 2) Instantiate the core
// This is needed to check if the core supports savestates
if (latest_savestate != null)
tmp_live_savestate = latest_savestate.clone_in_tmp ();
@@ -161,7 +159,7 @@ public class Games.RetroRunner : Object, Runner {
tmp_live_savestate = Savestate.create_empty_in_tmp (game.platform, get_core_id ());
instantiate_core (tmp_live_savestate.get_save_directory_path ());
- // Step 4) Preview the latest savestate --------------------------------
+ // Step 3) Preview the latest savestate --------------------------------
if (latest_savestate != null)
preview_savestate (latest_savestate);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]