[balsa/drop-is-directory] Drop LibBalsaMailbox:is_directory

[Peter Bloomfield <peterb src gnome org>]

commit af7be21eaf6367854bdf7065518038b9c76d94ac
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date:   Mon Mar 9 14:43:14 2020 -0400

    Drop LibBalsaMailbox:is_directory
    
    It was a write-only flag.
    
    * libbalsa/mailbox.c (libbalsa_mailbox_init),
      (libbalsa_mailbox_set_msg_tree_changed):
    * libbalsa/mailbox.h:
    * libbalsa/mailbox_maildir.c (libbalsa_mailbox_maildir_new):
    * libbalsa/mailbox_mbox.c (libbalsa_mailbox_mbox_new):
    * libbalsa/mailbox_mh.c (libbalsa_mailbox_mh_new):

 ChangeLog                  | 13 +++++++++++++
 libbalsa/mailbox.c         | 12 ------------
 libbalsa/mailbox.h         |  1 -
 libbalsa/mailbox_maildir.c |  2 --
 libbalsa/mailbox_mbox.c    |  2 --
 libbalsa/mailbox_mh.c      |  2 --
 6 files changed, 13 insertions(+), 19 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index ccfb3c6ba..328523e44 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2020-03-09  Peter Bloomfield  <pbloomfield bellsouth net>
+
+       Drop LibBalsaMailbox:is_directory
+
+       It was a write-only flag.
+
+       * libbalsa/mailbox.c (libbalsa_mailbox_init),
+       (libbalsa_mailbox_set_msg_tree_changed):
+       * libbalsa/mailbox.h:
+       * libbalsa/mailbox_maildir.c (libbalsa_mailbox_maildir_new):
+       * libbalsa/mailbox_mbox.c (libbalsa_mailbox_mbox_new):
+       * libbalsa/mailbox_mh.c (libbalsa_mailbox_mh_new):
+
 2020-03-06  Peter Bloomfield  <pbloomfield bellsouth net>
 
        mailbox: Make cache-message a class method
diff --git a/libbalsa/mailbox.c b/libbalsa/mailbox.c
index fbc90d000..25a9e3f87 100644
--- a/libbalsa/mailbox.c
+++ b/libbalsa/mailbox.c
@@ -155,7 +155,6 @@ struct _LibBalsaMailboxPrivate {
     guint run_filters_idle_id;
     guint sort_idle_id;
 
-    gboolean is_directory : 1;
     gboolean readonly : 1;
     gboolean view_filter_pending : 1;  /* a view filter has been set
                                         * but the view has not been updated */
@@ -268,7 +267,6 @@ libbalsa_mailbox_init(LibBalsaMailbox * mailbox)
     LibBalsaMailboxPrivate *priv = libbalsa_mailbox_get_instance_private(mailbox);
 
     g_rec_mutex_init(&priv->rec_mutex);
-    priv->is_directory = FALSE;
 
     priv->config_prefix = NULL;
     priv->name = NULL;
@@ -4988,16 +4986,6 @@ libbalsa_mailbox_set_msg_tree_changed(LibBalsaMailbox * mailbox, gboolean change
     priv->msg_tree_changed = !!changed;
 }
 
-void
-libbalsa_mailbox_set_is_directory(LibBalsaMailbox * mailbox, gboolean is_directory)
-{
-    LibBalsaMailboxPrivate *priv = libbalsa_mailbox_get_instance_private(mailbox);
-
-    g_return_if_fail(LIBBALSA_IS_MAILBOX(mailbox));
-
-    priv->is_directory = !!is_directory;
-}
-
 void
 libbalsa_mailbox_set_readonly(LibBalsaMailbox * mailbox, gboolean readonly)
 {
diff --git a/libbalsa/mailbox.h b/libbalsa/mailbox.h
index 18bb6b3a4..1ba5b164a 100644
--- a/libbalsa/mailbox.h
+++ b/libbalsa/mailbox.h
@@ -632,7 +632,6 @@ void libbalsa_mailbox_set_filters(LibBalsaMailbox * mailbox, GSList * filters);
 void libbalsa_mailbox_set_url(LibBalsaMailbox * mailbox, const gchar * url);
 void libbalsa_mailbox_set_first_unread(LibBalsaMailbox * mailbox, guint first);
 void libbalsa_mailbox_set_msg_tree_changed(LibBalsaMailbox * mailbox, gboolean changed);
-void libbalsa_mailbox_set_is_directory(LibBalsaMailbox * mailbox, gboolean is_directory);
 void libbalsa_mailbox_set_readonly(LibBalsaMailbox * mailbox, gboolean readonly);
 void libbalsa_mailbox_set_no_reassemble(LibBalsaMailbox * mailbox,
                                         gboolean no_reassemble);
diff --git a/libbalsa/mailbox_maildir.c b/libbalsa/mailbox_maildir.c
index b5d7651fe..7194a5fe9 100644
--- a/libbalsa/mailbox_maildir.c
+++ b/libbalsa/mailbox_maildir.c
@@ -243,8 +243,6 @@ libbalsa_mailbox_maildir_new(const gchar * path, gboolean create)
 
     mailbox = g_object_new(LIBBALSA_TYPE_MAILBOX_MAILDIR, NULL);
 
-    libbalsa_mailbox_set_is_directory(mailbox, TRUE);
-
     if (libbalsa_mailbox_local_set_path(LIBBALSA_MAILBOX_LOCAL(mailbox),
                                         path, create) != 0) {
         g_object_unref(mailbox);
diff --git a/libbalsa/mailbox_mbox.c b/libbalsa/mailbox_mbox.c
index bbf3597c3..405e1e21b 100644
--- a/libbalsa/mailbox_mbox.c
+++ b/libbalsa/mailbox_mbox.c
@@ -192,8 +192,6 @@ libbalsa_mailbox_mbox_new(const gchar * path, gboolean create)
 
     mailbox = g_object_new(LIBBALSA_TYPE_MAILBOX_MBOX, NULL);
 
-    libbalsa_mailbox_set_is_directory(mailbox, FALSE);
-
     if (libbalsa_mailbox_local_set_path(LIBBALSA_MAILBOX_LOCAL(mailbox),
                                         path, create) != 0) {
        g_object_unref(mailbox);
diff --git a/libbalsa/mailbox_mh.c b/libbalsa/mailbox_mh.c
index efe183a83..5dc6e371b 100644
--- a/libbalsa/mailbox_mh.c
+++ b/libbalsa/mailbox_mh.c
@@ -201,8 +201,6 @@ libbalsa_mailbox_mh_new(const gchar * path, gboolean create)
 
     mailbox = g_object_new(LIBBALSA_TYPE_MAILBOX_MH, NULL);
 
-    libbalsa_mailbox_set_is_directory(mailbox, TRUE);
-
     if (libbalsa_mailbox_local_set_path(LIBBALSA_MAILBOX_LOCAL(mailbox),
                                         path, create) != 0) {
        g_object_unref(mailbox);