[glib-networking/wip/nacho/fix-libsoup-loop: 3/3] connection: fix unit test to not assert the error

[Michael Catanzaro <mcatanzaro src gnome org>]

commit 3583e4d449c8054936dc96f333ffcc0dcae7292b
Author: Ignacio Casal Quinteiro <qignacio amazon com>
Date:   Fri Mar 13 13:54:19 2020 +0100

    connection: fix unit test to not assert the error
    
    This is kind of a small improvement since at least now sometimes
    we get an error but it still seems flaky.

 tls/tests/connection.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
---
diff --git a/tls/tests/connection.c b/tls/tests/connection.c
index 21a150a..61bf09b 100644
--- a/tls/tests/connection.c
+++ b/tls/tests/connection.c
@@ -966,8 +966,9 @@ test_invalid_chain_with_alternative_ca_cert (TestConnection *test,
 #ifdef BACKEND_IS_GNUTLS
   g_assert_error (test->server_error, G_TLS_ERROR, G_TLS_ERROR_NOT_TLS);
 #elif defined(BACKEND_IS_OPENSSL)
-  /* FIXME: This is not OK. There should be an error here. */
-  g_assert_no_error (test->server_error);
+  /* FIXME: This is not OK. There should be a NOT_TLS errors. But some times
+   * we either get no error or BROKEN_PIPE
+   */
 #endif
 }
 
@@ -1466,8 +1467,9 @@ test_failed_connection (TestConnection *test,
 #ifdef BACKEND_IS_GNUTLS
   g_assert_error (test->server_error, G_TLS_ERROR, G_TLS_ERROR_NOT_TLS);
 #elif defined(BACKEND_IS_OPENSSL)
-  /* FIXME: This is not OK. There should be an error here. */
-  g_assert_no_error (test->server_error);
+  /* FIXME: This is not OK. There should be a NOT_TLS errors. But some times
+   * we either get no error or BROKEN_PIPE
+   */
 #endif
 }
 
@@ -1560,7 +1562,9 @@ test_connection_socket_client_failed (TestConnection *test,
 #ifdef BACKEND_IS_GNUTLS
   g_assert_error (test->server_error, G_TLS_ERROR, G_TLS_ERROR_NOT_TLS);
 #else
-  /* FIXME: This is not OK. There should be an error here. */
+  /* FIXME: This is not OK. There should be a NOT_TLS errors. But some times
+   * we either get no error or BROKEN_PIPE
+   */
 #endif
 
   g_object_unref (client);