[gnome-maps] placeListRow: Fix short detail label



commit 7c4a796e7097b08913e132401b39eb88be3e44de
Author: James Westman <james flyingpimonster net>
Date:   Thu Mar 12 12:35:28 2020 -0500

    placeListRow: Fix short detail label
    
    The detail label in place list rows was previously capped at 15-40 characters
    (depending on where it appeared). This has been removed so that the label
    takes all available space before ellipsizing.

 src/favoritesPopover.js | 1 -
 src/placeListRow.js     | 4 ----
 src/placePopover.js     | 1 -
 3 files changed, 6 deletions(-)
---
diff --git a/src/favoritesPopover.js b/src/favoritesPopover.js
index 8386eaa0..097864ba 100644
--- a/src/favoritesPopover.js
+++ b/src/favoritesPopover.js
@@ -110,7 +110,6 @@ var FavoritesPopover = GObject.registerClass({
             let place = model.get_value(iter, PlaceStore.Columns.PLACE);
 
             let row = new PlaceListRow.PlaceListRow({ place: place,
-                                                      maxChars: 15,
                                                       can_focus: true });
             this._list.add(row);
             rows++;
diff --git a/src/placeListRow.js b/src/placeListRow.js
index 836c36fb..68ed931c 100644
--- a/src/placeListRow.js
+++ b/src/placeListRow.js
@@ -42,9 +42,6 @@ var PlaceListRow = GObject.registerClass({
         let searchString = params.searchString || '';
         delete params.searchString;
 
-        this._maxChars = params.maxChars || 40;
-        delete params.maxChars;
-
         let type = params.type;
         delete params.type;
 
@@ -60,7 +57,6 @@ var PlaceListRow = GObject.registerClass({
         let markup = GLib.markup_escape_text(formatter.title, -1);
 
         this._name.label = this._boldMatch(markup, searchString);
-        this._details.max_width_chars = this._maxChars;
         this._details.label = GLib.markup_escape_text(formatter.getDetailsString(),-1);
         this._icon.gicon = place.icon;
 
diff --git a/src/placePopover.js b/src/placePopover.js
index 75d1382a..d3c1d006 100644
--- a/src/placePopover.js
+++ b/src/placePopover.js
@@ -129,7 +129,6 @@ var PlacePopover = GObject.registerClass({
         let row = new PlaceListRow.PlaceListRow({ place: place,
                                                   searchString: searchString,
                                                   type: type,
-                                                  maxChars: this._maxChars,
                                                   can_focus: true });
         this._list.add(row);
     }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]