[gnome-shell] extensionDownloader: Stop handling 'blacklist' operation



commit cc347bf6d84615c3129d48de97197f46035228cc
Author: Florian Müllner <fmuellner gnome org>
Date:   Thu Mar 26 00:39:29 2020 +0100

    extensionDownloader: Stop handling 'blacklist' operation
    
    Blacklist support was added all the way back in commit 1e286e43, but
    the code had been defunctional until recently. While uninstalling an
    extension that has been blacklisted makes sense off-hand, unfortunately
    we don't know if an extension was *actually* blacklisted:
    
    The website returns that operation for any extensions for which it
    doesn't find any versions that match the shell version. That is, the
    most likely reason is that the user updated to a new GNOME release
    which the extension doesn't support yet.
    
    It doesn't look like the website is going to change that behavior any
    time soon[0], so drop the 'blacklist' handling for the time being.
    
    [0] https://gitlab.gnome.org/Infrastructure/extensions-web/-/issues/95
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1132

 js/ui/extensionDownloader.js | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js
index b399394b1b..306aaf14fb 100644
--- a/js/ui/extensionDownloader.js
+++ b/js/ui/extensionDownloader.js
@@ -156,9 +156,7 @@ function checkForUpdates() {
         let operations = JSON.parse(message.response_body.data);
         for (let uuid in operations) {
             let operation = operations[uuid];
-            if (operation == 'blacklist')
-                uninstallExtension(uuid);
-            else if (operation == 'upgrade' || operation == 'downgrade')
+            if (operation === 'upgrade' || operation === 'downgrade')
                 downloadExtensionUpdate(uuid);
         }
     });


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]