[gnome-control-center/565-screen-sharing-label-seems-to-be-not-connected-properly-to-checkbox] sharing: Set label for checkbox properly
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/565-screen-sharing-label-seems-to-be-not-connected-properly-to-checkbox] sharing: Set label for checkbox properly
- Date: Mon, 30 Mar 2020 14:55:31 +0000 (UTC)
commit b016ab86d720c10e74ee0222d88ae38436168fac
Author: António Fernandes <antoniojpfernandes gmail com>
Date: Mon Mar 30 14:55:23 2020 +0000
sharing: Set label for checkbox properly
The Screen Sharing dialog used to have a switch, which was changed to a
checkbox in 8b689614315089781e604b8e76521c1e926bbdac
However, unlike switches, checkboxes are expected to have clicable labels
Let's set the label properly, instead of doing it the switch way.
Fixes https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/565
panels/sharing/cc-sharing-panel.ui | 36 ++++++------------------------------
1 file changed, 6 insertions(+), 30 deletions(-)
---
diff --git a/panels/sharing/cc-sharing-panel.ui b/panels/sharing/cc-sharing-panel.ui
index d9e0d08b2..c55d8f09f 100644
--- a/panels/sharing/cc-sharing-panel.ui
+++ b/panels/sharing/cc-sharing-panel.ui
@@ -562,37 +562,13 @@
<property name="orientation">vertical</property>
<property name="spacing">12</property>
<child>
- <object class="GtkBox" id="box6">
+ <object class="GtkCheckButton" id="remote_control_checkbutton">
+ <property name="label" translatable="yes">_Allow connections to control the
screen</property>
<property name="visible">True</property>
- <property name="can_focus">False</property>
- <property name="spacing">6</property>
- <child>
- <object class="GtkLabel" id="remote_control_label">
- <property name="visible">True</property>
- <property name="can_focus">False</property>
- <property name="halign">start</property>
- <property name="hexpand">True</property>
- <property name="label" translatable="yes">_Allow connections to control the
screen</property>
- <property name="use_underline">True</property>
- <property name="mnemonic_widget">remote_control_checkbutton</property>
- </object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">True</property>
- <property name="position">1</property>
- </packing>
- </child>
- <child>
- <object class="GtkCheckButton" id="remote_control_checkbutton">
- <property name="visible">True</property>
- <property name="can_focus">True</property>
- </object>
- <packing>
- <property name="expand">False</property>
- <property name="fill">True</property>
- <property name="position">0</property>
- </packing>
- </child>
+ <property name="can_focus">True</property>
+ <property name="receives_default">False</property>
+ <property name="draw_indicator">True</property>
+ <property name="use_underline">True</property>
</object>
<packing>
<property name="expand">False</property>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]