[gnome-music] Remove no_show_all property

[Jean Felder <jfelder src gnome org>]

commit 6633ecea3a3a84d679ec380384c58b6bbd01ab71
Author: Jean Felder <jfelder src gnome org>
Date:   Sat May 2 13:39:11 2020 +0200

    Remove no_show_all property
    
    The application does not use show_all anymore. Thus, there is no need
    for this property.
    This is some prep-work for a GTK4 port.
    
    Related: #320

 data/ui/AlbumWidget.ui           | 2 --
 data/ui/DiscBox.ui               | 1 -
 data/ui/HeaderBar.ui             | 1 -
 data/ui/PlayerToolbar.ui         | 1 -
 data/ui/PlaylistControls.ui      | 1 -
 data/ui/SearchHeaderBar.ui       | 1 -
 data/ui/SongWidget.ui            | 3 ---
 gnomemusic/widgets/songwidget.py | 4 ----
 8 files changed, 14 deletions(-)
---
diff --git a/data/ui/AlbumWidget.ui b/data/ui/AlbumWidget.ui
index 010fdfec..9fdb87cf 100644
--- a/data/ui/AlbumWidget.ui
+++ b/data/ui/AlbumWidget.ui
@@ -161,7 +161,6 @@
                       <object class="GtkLabel" id="_composer_label">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="no_show_all">True</property>
                         <property name="halign">end</property>
                         <property name="margin_top">2</property>
                         <property name="margin_bottom">2</property>
@@ -180,7 +179,6 @@
                       <object class="GtkLabel" id="_composer_info_label">
                         <property name="visible">True</property>
                         <property name="can_focus">False</property>
-                        <property name="no_show_all">True</property>
                         <property name="halign">start</property>
                         <property name="margin_top">2</property>
                         <property name="margin_bottom">2</property>
diff --git a/data/ui/DiscBox.ui b/data/ui/DiscBox.ui
index a769b65c..5d2ce0bf 100644
--- a/data/ui/DiscBox.ui
+++ b/data/ui/DiscBox.ui
@@ -17,7 +17,6 @@
             <property name="can_focus">False</property>
             <property name="halign">fill</property>
             <!-- <property name="hexpand">True</property> -->
-            <property name="no_show_all">True</property>
             <property name="xalign">0.0</property>
             <style>
               <class name="disc-label"/>
diff --git a/data/ui/HeaderBar.ui b/data/ui/HeaderBar.ui
index d24359f8..c0e8578a 100644
--- a/data/ui/HeaderBar.ui
+++ b/data/ui/HeaderBar.ui
@@ -56,7 +56,6 @@
     <child>
       <object class="GtkButton" id="_cancel_button">
         <property name="visible">False</property>
-        <property name="no_show_all">True</property>
         <property name="can_focus">False</property>
         <property name="label" translatable="yes">_Cancel</property>
         <property name="use_underline">True</property>
diff --git a/data/ui/PlayerToolbar.ui b/data/ui/PlayerToolbar.ui
index 78888f6e..142a74fc 100644
--- a/data/ui/PlayerToolbar.ui
+++ b/data/ui/PlayerToolbar.ui
@@ -53,7 +53,6 @@
   </object>
   <template class="PlayerToolbar" parent="GtkActionBar">
     <property name="can_focus">False</property>
-    <property name="no_show_all">True</property>
     <child>
       <object class="GtkBox" id="buttons">
         <property name="visible">True</property>
diff --git a/data/ui/PlaylistControls.ui b/data/ui/PlaylistControls.ui
index d0db94b0..0c52d1b8 100644
--- a/data/ui/PlaylistControls.ui
+++ b/data/ui/PlaylistControls.ui
@@ -68,7 +68,6 @@
             <child>
               <object class="GtkButton" id="_rename_done_button">
                 <property name="visible">True</property>
-                <property name="no_show_all">True</property>
                 <property name="can_focus">True</property>
                 <property name="has_focus">True</property>
                 <property name="receives_default">True</property>
diff --git a/data/ui/SearchHeaderBar.ui b/data/ui/SearchHeaderBar.ui
index b894dbf2..48bd0795 100644
--- a/data/ui/SearchHeaderBar.ui
+++ b/data/ui/SearchHeaderBar.ui
@@ -33,7 +33,6 @@
     <child>
       <object class="GtkButton" id="_cancel_button">
         <property name="visible">False</property>
-        <property name="no_show_all">True</property>
         <property name="can_focus">False</property>
         <property name="label" translatable="yes">_Cancel</property>
         <property name="use_underline">True</property>
diff --git a/data/ui/SongWidget.ui b/data/ui/SongWidget.ui
index 63cfc100..240a707e 100644
--- a/data/ui/SongWidget.ui
+++ b/data/ui/SongWidget.ui
@@ -20,7 +20,6 @@
             <signal name="drag-begin" handler="_on_drag_begin"/>
             <signal name="drag-end" handler="_on_drag_end"/>
             <signal name="drag_data_get" handler="_on_drag_data_get"/>
-           <property name="no_show_all">True</property>
             <child>
               <object class="GtkImage">
                 <property name="visible">True</property>
@@ -55,7 +54,6 @@
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
                 <property name="receives_default">False</property>
-                <property name="no_show_all">True</property>
                 <property name="draw_indicator">True</property>
                 <signal name="toggled" handler="_on_select_button_toggled"/>
               </object>
@@ -144,7 +142,6 @@
               <object class="GtkLabel" id="_duration_label">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
-                <property name="no_show_all">True</property>
                 <property name="halign">end</property>
                 <property name="valign">center</property>
                 <property name="hexpand">True</property>
diff --git a/gnomemusic/widgets/songwidget.py b/gnomemusic/widgets/songwidget.py
index c022fff1..60246126 100644
--- a/gnomemusic/widgets/songwidget.py
+++ b/gnomemusic/widgets/songwidget.py
@@ -124,7 +124,6 @@ class SongWidget(Gtk.EventBox):
 
         self._play_icon.set_from_icon_name(
             'media-playback-start-symbolic', Gtk.IconSize.SMALL_TOOLBAR)
-        self._play_icon.set_no_show_all(True)
 
         self.props.coresong.bind_property(
             'selected', self._select_button, 'active',
@@ -133,7 +132,6 @@ class SongWidget(Gtk.EventBox):
         self.bind_property(
             'show-duration', self._duration_label, 'visible',
             GObject.BindingFlags.SYNC_CREATE)
-        self._duration_label.set_no_show_all(True)
         self.bind_property(
             'show-favorite', self._star_eventbox, 'visible',
             GObject.BindingFlags.SYNC_CREATE)
@@ -153,8 +151,6 @@ class SongWidget(Gtk.EventBox):
         if not self.props.coresong.props.is_tracker:
             self._star_stack.props.visible_child_name = "empty"
 
-        self._number_label.props.no_show_all = True
-
         if can_dnd is True:
             self._dnd_eventbox.props.visible = True
             self._drag_widget = None