[nautilus] files-view: Disable select-all while directory is loading
- From: António Fernandes <antoniof src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [nautilus] files-view: Disable select-all while directory is loading
- Date: Sun, 10 May 2020 19:13:14 +0000 (UTC)
commit 12b0e55ee99257d43165eb77ea5f13e97ba6e62d
Author: Ujjwal Kumar <ujjwalkumar0501 gmail com>
Date: Mon Apr 6 21:46:21 2020 +0530
files-view: Disable select-all while directory is loading
In the current state, it is possible to perform selection
while the directory is loading which in some cases, may not
select all the items.
Performing select-all only selects the items that are loaded,
till the point of performing the action.
Since the loading state is already maintained, we can put a
check for an on-going directory load while updating actions state.
Closes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/1389
src/nautilus-files-view.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/nautilus-files-view.c b/src/nautilus-files-view.c
index fa6156fec..5be047781 100644
--- a/src/nautilus-files-view.c
+++ b/src/nautilus-files-view.c
@@ -7766,7 +7766,8 @@ real_update_actions_state (NautilusFilesView *view)
action = g_action_map_lookup_action (G_ACTION_MAP (view_action_group),
"select-all");
g_simple_action_set_enabled (G_SIMPLE_ACTION (action),
- !nautilus_files_view_is_empty (view));
+ !nautilus_files_view_is_empty (view) &&
+ !priv->loading);
/* Toolbar menu actions */
g_action_group_change_action_state (view_action_group,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]