[gtk/matthiasc/for-master: 24/24] printoperation-unix: Fix a use-after-free
- From: Matthias Clasen <matthiasc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk/matthiasc/for-master: 24/24] printoperation-unix: Fix a use-after-free
- Date: Tue, 12 May 2020 18:11:38 +0000 (UTC)
commit 09ea880a43093d3d8e11344b0aa338667cafb50f
Author: Matthias Clasen <mclasen redhat com>
Date: Tue May 12 14:09:51 2020 -0400
printoperation-unix: Fix a use-after-free
It turns out that finish_print destroys the
PrintResponseData, so we can't access it afterwards.
gtk/gtkprintoperation-unix.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/gtk/gtkprintoperation-unix.c b/gtk/gtkprintoperation-unix.c
index f6b2195e17..87d97e240e 100644
--- a/gtk/gtkprintoperation-unix.c
+++ b/gtk/gtkprintoperation-unix.c
@@ -650,6 +650,9 @@ handle_print_response (GtkWidget *dialog,
gtk_print_operation_set_print_settings (rdata->op, settings);
g_signal_emit_by_name (rdata->op, "custom-widget-apply", rdata->op->priv->custom_widget);
}
+
+ if (rdata->loop)
+ g_main_loop_quit (rdata->loop);
finish_print (rdata, printer, page_setup, settings, page_setup_set);
@@ -657,9 +660,6 @@ handle_print_response (GtkWidget *dialog,
g_object_unref (settings);
gtk_window_destroy (GTK_WINDOW (pd));
-
- if (rdata->loop)
- g_main_loop_quit (rdata->loop);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]