[gnome-shell] extensionSystem: Disable extension before unloading stylesheet
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] extensionSystem: Disable extension before unloading stylesheet
- Date: Wed, 13 May 2020 19:13:29 +0000 (UTC)
commit 6d5e93b00b5b4ce5315276e071a98c8db5ff6463
Author: Florian Müllner <fmuellner gnome org>
Date: Wed May 13 20:10:56 2020 +0200
extensionSystem: Disable extension before unloading stylesheet
Removing a stylesheet from the theme will trigger a style update. There's
little point in updating the extension actors that are about to be destroyed
(hopefully), so call the extension's disable() function first.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2757
js/ui/extensionSystem.js | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
---
diff --git a/js/ui/extensionSystem.js b/js/ui/extensionSystem.js
index 1a34f19e9e..5a50b473ac 100644
--- a/js/ui/extensionSystem.js
+++ b/js/ui/extensionSystem.js
@@ -102,18 +102,18 @@ var ExtensionManager = class {
}
}
- if (extension.stylesheet) {
- let theme = St.ThemeContext.get_for_stage(global.stage).get_theme();
- theme.unload_stylesheet(extension.stylesheet);
- delete extension.stylesheet;
- }
-
try {
extension.stateObj.disable();
} catch (e) {
this.logExtensionError(uuid, e);
}
+ if (extension.stylesheet) {
+ let theme = St.ThemeContext.get_for_stage(global.stage).get_theme();
+ theme.unload_stylesheet(extension.stylesheet);
+ delete extension.stylesheet;
+ }
+
for (let i = 0; i < order.length; i++) {
let otherUuid = order[i];
try {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]