[gnome-software/misc-flatpak-fixes: 52/55] flatpak: Set app state to INSTALLED more consistently
- From: Matthew Leeds <mwleeds src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/misc-flatpak-fixes: 52/55] flatpak: Set app state to INSTALLED more consistently
- Date: Mon, 18 May 2020 15:31:59 +0000 (UTC)
commit 25978d36987a0e6caf170b6d56e83073e0614cb7
Author: Matthew Leeds <matthew leeds endlessm com>
Date: Mon Jan 27 12:51:18 2020 -0800
flatpak: Set app state to INSTALLED more consistently
In a couple places we were calling gs_flatpak_create_installed() but not
setting the app to AS_APP_STATE_INSTALLED. Fix that.
plugins/flatpak/gs-flatpak.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/plugins/flatpak/gs-flatpak.c b/plugins/flatpak/gs-flatpak.c
index a6460d43..4669c575 100644
--- a/plugins/flatpak/gs-flatpak.c
+++ b/plugins/flatpak/gs-flatpak.c
@@ -1066,6 +1066,8 @@ gs_flatpak_create_installed (GsFlatpak *self,
/* create new object */
origin = flatpak_installed_ref_get_origin (xref);
app = gs_flatpak_create_app (self, origin, FLATPAK_REF (xref));
+ if (gs_app_get_state (app) == AS_APP_STATE_UNKNOWN)
+ gs_app_set_state (app, AS_APP_STATE_INSTALLED);
gs_flatpak_set_metadata_installed (self, app, xref);
return g_steal_pointer (&app);
}
@@ -1087,8 +1089,6 @@ gs_flatpak_add_installed (GsFlatpak *self, GsAppList *list,
for (guint i = 0; i < xrefs->len; i++) {
FlatpakInstalledRef *xref = g_ptr_array_index (xrefs, i);
g_autoptr(GsApp) app = gs_flatpak_create_installed (self, xref);
- if (gs_app_get_state (app) == AS_APP_STATE_UNKNOWN)
- gs_app_set_state (app, AS_APP_STATE_INSTALLED);
gs_app_list_add (list, app);
}
@@ -1149,8 +1149,6 @@ gs_flatpak_add_sources (GsFlatpak *self, GsAppList *list,
flatpak_remote_get_name (xremote)) != 0)
continue;
related = gs_flatpak_create_installed (self, xref);
- if (gs_app_get_state (related) == AS_APP_STATE_UNKNOWN)
- gs_app_set_state (related, AS_APP_STATE_INSTALLED);
gs_app_add_related (app, related);
}
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]