[tracker-miners: 2/3] functional-tests: Add a new flac extraction test for gstreamer 1.18
- From: Sam Thursfield <sthursfield src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker-miners: 2/3] functional-tests: Add a new flac extraction test for gstreamer 1.18
- Date: Tue, 19 May 2020 20:56:04 +0000 (UTC)
commit cea52a29294689184371d887acb1326be0cf5852
Author: Jean Felder <jfelder src gnome org>
Date: Wed Feb 26 22:15:37 2020 +0100
functional-tests: Add a new flac extraction test for gstreamer 1.18
Gstreamer 1.18 introduced support for the following MusicBrainz
identifiers:
- track id (GST_TAG_MUSICBRAINZ_RELEASETRACKID)
- fingerprint id (GST_TAG_ACOUSTID_FINGERPRINT)
- release-group id (GST_TAG_MUSICBRAINZ_RELEASEGROUPID)
See:
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/-/merge_requests/252
A new test called 'flac-musicbrainz' is added to check that those tags
are correctly extraced for gstreamer 1.18.0. The existing 'flac' test is
now only executed for the previous versions of gstreamer. Boths tests
extract the information from the same audio file (flac.flac).
tests/functional-tests/meson.build | 9 ++-
.../audio/flac-musicbrainz.expected.json | 80 ++++++++++++++++++++++
2 files changed, 88 insertions(+), 1 deletion(-)
---
diff --git a/tests/functional-tests/meson.build b/tests/functional-tests/meson.build
index 402423eda..8a996432c 100644
--- a/tests/functional-tests/meson.build
+++ b/tests/functional-tests/meson.build
@@ -34,11 +34,18 @@ extractor_tests = [
'audio/mp3-id3v2.4-1',
'audio/mp3-id3v2.3-empty-artist-album',
'audio/mp3-id3v2.4-2',
- 'audio/flac',
'desktop/application',
'desktop/link-wikipedia-tracker'
]
+# Gstreamer 1.18 introduced support for some additionnals
+# MusicBrainz tags
+if gstreamer.found() and gstreamer.version() >= '1.18.0'
+ extractor_tests += 'audio/flac-musicbrainz'
+else
+ extractor_tests += 'audio/flac'
+endif
+
if libvorbis.found()
extractor_tests += 'audio/vorbis'
endif
diff --git a/tests/functional-tests/test-extraction-data/audio/flac-musicbrainz.expected.json
b/tests/functional-tests/test-extraction-data/audio/flac-musicbrainz.expected.json
new file mode 100644
index 000000000..b3b623a8a
--- /dev/null
+++ b/tests/functional-tests/test-extraction-data/audio/flac-musicbrainz.expected.json
@@ -0,0 +1,80 @@
+{
+ "test": {
+ "Filename": "flac.flac"
+ },
+ "metadata": {
+ "@type": [
+ "nfo:Audio",
+ "nmm:MusicPiece"
+ ],
+ "nfo:channels": "2",
+ "nfo:duration": "10",
+ "nfo:genre": "Rock",
+ "nfo:sampleRate": "44100",
+ "nie:comment": "no comment",
+ "nie:contentCreated": "2020-01-01T00:00:00+00:00",
+ "nie:copyright": "none",
+ "nie:title": "track title",
+ "nmm:trackNumber": "12",
+ "nmm:musicAlbum": {
+ "@type": "nmm:MusicAlbum",
+ "nie:title": "awesome album",
+ "nmm:albumTrackCount": "28",
+ "nmm:albumArtist": [
+ {
+ "@type": "nmm:Artist",
+ "nmm:artistName": "my album artist"
+ }
+ ],
+ "tracker:hasExternalReference": [
+ {
+ "@id": "https://musicbrainz.org/release/524387feg",
+ "@type": "tracker:ExternalReference",
+ "tracker:referenceSource": "https://musicbrainz.org/doc/Release",
+ "tracker:referenceIdentifier": "524387feg"
+ },
+ {
+ "@id": "https://musicbrainz.org/release-group/34-458923-kbe",
+ "@type": "tracker:ExternalReference",
+ "tracker:referenceSource": "https://musicbrainz.org/doc/Release_Group",
+ "tracker:referenceIdentifier": "34-458923-kbe"
+ }
+ ]
+ },
+ "nmm:musicAlbumDisc": {
+ "@type": "nmm:MusicAlbumDisc",
+ "nmm:setNumber": 1
+ },
+ "nmm:performer": {
+ "@type": "nmm:Artist",
+ "nmm:artistName": "my artist",
+ "tracker:hasExternalReference": [
+ {
+ "@id": "https://musicbrainz.org/artist/789-feg-7854",
+ "@type": "tracker:ExternalReference",
+ "tracker:referenceSource": "https://musicbrainz.org/doc/Artist",
+ "tracker:referenceIdentifier": "789-feg-7854"
+ }
+ ]
+ },
+ "tracker:hasExternalReference": [
+ {
+ "@id": "https://musicbrainz.org/recording/4-8-15-16-23-42-lost",
+ "@type": "tracker:ExternalReference",
+ "tracker:referenceSource": "https://musicbrainz.org/doc/Recording",
+ "tracker:referenceIdentifier": "4-8-15-16-23-42-lost"
+ },
+ {
+ "@id": "https://musicbrainz.org/track/dfgj-432-iu7",
+ "@type": "tracker:ExternalReference",
+ "tracker:referenceSource": "https://musicbrainz.org/doc/Track",
+ "tracker:referenceIdentifier": "dfgj-432-iu7"
+ }
+ ],
+ "nfo:hasHash": {
+ "@type": "nfo:hasHash",
+ "nfo:hashAlgorithm": "chromaprint",
+ "nfo:hashValue": "123453215"
+ }
+ }
+}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]