[orca] Revert "Don't present image children of links if the image lacks an explicit name"
- From: Joanmarie Diggs <joanied src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [orca] Revert "Don't present image children of links if the image lacks an explicit name"
- Date: Sat, 23 May 2020 17:49:48 +0000 (UTC)
commit 714c0d6fe9683978a9b3b675bfe280188e971b3b
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Sat May 23 13:49:19 2020 -0400
    Revert "Don't present image children of links if the image lacks an explicit name"
    
    This reverts commit 691f4607d5892932cfdfa9202d262c10c35b3dd5.
    
    It introduced a weird side effect.
 src/orca/scripts/web/script_utilities.py | 4 ++++
 1 file changed, 4 insertions(+)
---
diff --git a/src/orca/scripts/web/script_utilities.py b/src/orca/scripts/web/script_utilities.py
index 118a08bd5..16501f18a 100644
--- a/src/orca/scripts/web/script_utilities.py
+++ b/src/orca/scripts/web/script_utilities.py
@@ -3766,6 +3766,10 @@ class Utilities(script_utilities.Utilities):
             rv = False
         if rv and obj.getState().contains(pyatspi.STATE_FOCUSABLE):
             rv = False
+        if rv and obj.parent.getRole() == pyatspi.ROLE_LINK:
+            uri = self.uri(obj.parent)
+            if uri and not uri.startswith('javascript'):
+                rv = False
         if rv and 'Image' in pyatspi.listInterfaces(obj):
             image = obj.queryImage()
             if image.imageDescription:
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]