[tracker/tracker-3.0: 2/4] libtracker-data: Issue fatal g_error() if next resource ID cannot be found
- From: Sam Thursfield <sthursfield src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [tracker/tracker-3.0: 2/4] libtracker-data: Issue fatal g_error() if next resource ID cannot be found
 
- Date: Thu,  5 Nov 2020 12:57:51 +0000 (UTC)
 
commit 720f923a26fbdb7a5e9889c42b22f2e09167dce2
Author: Carlos Garnacho <carlosg gnome org>
Date:   Sat Oct 31 15:52:33 2020 +0100
    libtracker-data: Issue fatal g_error() if next resource ID cannot be found
    
    This breaks fundamental assumptions (e.g. that getting a next resource ID is
    not failable), breaks even further if those resources don't get the specified
    ID.
    
    It is preferrable to hard error altogether, and let users report the
    backtrace/error.
    
    Related: https://gitlab.gnome.org/GNOME/tracker-miners/-/issues/150
 src/libtracker-data/tracker-data-update.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/libtracker-data/tracker-data-update.c b/src/libtracker-data/tracker-data-update.c
index 4b558d271..829ce3846 100644
--- a/src/libtracker-data/tracker-data-update.c
+++ b/src/libtracker-data/tracker-data-update.c
@@ -800,7 +800,7 @@ ensure_resource_id (TrackerData *data,
                }
 
                if (error) {
-                       g_critical ("Could not ensure resource existence: %s", error->message);
+                       g_error ("Could not ensure resource existence: %s", error->message);
                        g_error_free (error);
                }
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]