[gnome-break-timer] Add a TODO to remove some slow code in a UI event
- From: Dylan McCall <dylanmccall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-break-timer] Add a TODO to remove some slow code in a UI event
- Date: Thu, 19 Nov 2020 08:13:12 +0000 (UTC)
commit e78043defbfe36928b0776ef3f641a53b138699a
Author: Dylan McCall <dylan dylanmccall ca>
Date: Thu Nov 19 00:12:32 2020 -0800
Add a TODO to remove some slow code in a UI event
src/daemon/main.vala | 2 +-
src/settings/MainWindow.vala | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/daemon/main.vala b/src/daemon/main.vala
index 18d83aa..cf7f8ed 100644
--- a/src/daemon/main.vala
+++ b/src/daemon/main.vala
@@ -28,7 +28,7 @@ public int main (string[] args) {
return status;
}
-void sigint_cb (int signal_number) {
+static void sigint_cb (int signal_number) {
application.quit ();
}
diff --git a/src/settings/MainWindow.vala b/src/settings/MainWindow.vala
index 1de741b..4192c80 100644
--- a/src/settings/MainWindow.vala
+++ b/src/settings/MainWindow.vala
@@ -286,6 +286,7 @@ public class MainWindow : Gtk.ApplicationWindow, GLib.Initable {
// This feels kind of dirty and it would be nice if there was a better
// way.
// TODO: Can we pre-select org.gnome.BreakTimer?
+ // TODO: This should be asynchronous
GLib.Variant[] parameters = {
new GLib.Variant ("(sav)", "applications")
@@ -299,7 +300,7 @@ public class MainWindow : Gtk.ApplicationWindow, GLib.Initable {
GLib.DBusProxyFlags.DO_NOT_AUTO_START,
null
);
- control_center_application.activate_action("launch-panel", parameters, platform_data);
+ control_center_application.activate_action ("launch-panel", parameters, platform_data);
} catch (GLib.IOError error) {
GLib.warning ("Error connecting to org.gnome.ControlCenter: %s", error.message);
return false;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]