[gedit] View: remove context menu in the margin to toggle line numbers
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gedit] View: remove context menu in the margin to toggle line numbers
- Date: Tue, 24 Nov 2020 19:32:36 +0000 (UTC)
commit cd00ffcff92c10ba979c99e333dbe1da2b72ae7b
Author: Sébastien Wilmet <swilmet gnome org>
Date: Tue Nov 24 20:17:49 2020 +0100
View: remove context menu in the margin to toggle line numbers
That small feature was added in 2009:
commit fb4ced951e10fdd7a28cd95baaf043893e73d7e5
When doing a right click in the left margin/gutter, a context menu
appeared with only one item: to toggle the line numbers visibility.
I don't think it is great to add such options a bit everywhere in the
GUI. The gedit statusbar already contains, nowadays, buttons to toggle
certain settings, including the line numbers visibility. The option is
also of course available in the preferences dialog, where it is the
natural place to change such settings.
Also, when the left gutter contained *only* the line numbers, then doing
a right click to hide the line numbers, the user might not know directly
where to revert the change and display the line numbers again, since the
left gutter is gone.
So, I prefer to remove that small feature. I don't think it was a
well-known feature in any case, since it's a bit hidden behind a right
click at a specific place.
gedit/gedit-view.c | 51 ---------------------------------------------------
1 file changed, 51 deletions(-)
---
diff --git a/gedit/gedit-view.c b/gedit/gedit-view.c
index 57a813175..3a97b54a7 100644
--- a/gedit/gedit-view.c
+++ b/gedit/gedit-view.c
@@ -417,56 +417,6 @@ gedit_view_drag_drop (GtkWidget *widget,
return drop_zone;
}
-static void
-show_line_numbers_menu (GeditView *view,
- GdkEventButton *event)
-{
- GtkWidget *menu;
- GtkWidget *item;
- GeditSettings *settings;
- GSettings *editor_settings;
-
- menu = gtk_menu_new ();
-
- item = gtk_check_menu_item_new_with_mnemonic (_("_Display line numbers"));
- gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (item),
- gtk_source_view_get_show_line_numbers (GTK_SOURCE_VIEW (view)));
-
- settings = _gedit_settings_get_singleton ();
- editor_settings = _gedit_settings_peek_editor_settings (settings);
-
- g_settings_bind (editor_settings, GEDIT_SETTINGS_DISPLAY_LINE_NUMBERS,
- item, "active",
- G_SETTINGS_BIND_SET);
-
- gtk_menu_shell_append (GTK_MENU_SHELL (menu), item);
-
- g_signal_connect (menu,
- "selection-done",
- G_CALLBACK (gtk_widget_destroy),
- NULL);
-
- gtk_widget_show_all (menu);
- gtk_menu_popup_at_pointer (GTK_MENU (menu), (GdkEvent *)event);
-}
-
-static gboolean
-gedit_view_button_press_event (GtkWidget *widget,
- GdkEventButton *event)
-{
- if ((event->type == GDK_BUTTON_PRESS) &&
- (event->button == GDK_BUTTON_SECONDARY) &&
- (event->window == gtk_text_view_get_window (GTK_TEXT_VIEW (widget),
- GTK_TEXT_WINDOW_LEFT)))
- {
- show_line_numbers_menu (GEDIT_VIEW (widget), event);
-
- return GDK_EVENT_STOP;
- }
-
- return GTK_WIDGET_CLASS (gedit_view_parent_class)->button_press_event (widget, event);
-}
-
static void
extension_added (PeasExtensionSet *extensions,
PeasPluginInfo *info,
@@ -684,7 +634,6 @@ gedit_view_class_init (GeditViewClass *klass)
widget_class->drag_data_received = gedit_view_drag_data_received;
widget_class->drag_drop = gedit_view_drag_drop;
- widget_class->button_press_event = gedit_view_button_press_event;
widget_class->realize = gedit_view_realize;
widget_class->unrealize = gedit_view_unrealize;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]