[gdm/wip/nacho/crash-backport-3-36: 1/2] manager: Fix possible crash by initializing display




commit 0c6e50b77e10093ab6cfe8de0d7295c3501fbf64
Author: Benjamin Berg <bberg redhat com>
Date:   Fri Aug 21 12:14:32 2020 +0200

    manager: Fix possible crash by initializing display
    
    Some people insist on running sessions in ways where we cannot detect
    them properly. In that case, we shouldn't find a display, but the
    variable was not initialized and we could end up accessing random memory
    resulting in a crash.
    
    Fix it by adding the missing initializer.
    
    Closes: #555

 daemon/gdm-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/daemon/gdm-manager.c b/daemon/gdm-manager.c
index efcce9b6..25beecb5 100644
--- a/daemon/gdm-manager.c
+++ b/daemon/gdm-manager.c
@@ -811,7 +811,7 @@ gdm_manager_handle_register_session (GdmDBusManager        *manager,
                                      GVariant              *details)
 {
         GdmManager      *self = GDM_MANAGER (manager);
-        GdmDisplay      *display;
+        GdmDisplay      *display = NULL;
         const char      *sender;
         GDBusConnection *connection;
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]