[epiphany/wip/exalm/tabs] Silence the CI

[Alexander Mikhaylenko <alexm src gnome org>]

commit 6446fac5909099e3f2c832094830001285e053fa
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Sun Sep 6 22:21:05 2020 +0500

    Silence the CI

 src/ephy-page-row.c | 73 +----------------------------------------------------
 src/ephy-session.c  |  2 --
 src/ephy-tab-view.c | 15 -----------
 src/ephy-window.c   |  4 ---
 4 files changed, 1 insertion(+), 93 deletions(-)
---
diff --git a/src/ephy-page-row.c b/src/ephy-page-row.c
index 299b1b68c..6cd5dce20 100644
--- a/src/ephy-page-row.c
+++ b/src/ephy-page-row.c
@@ -51,37 +51,6 @@ static guint signals[LAST_SIGNAL];
 
 G_DEFINE_TYPE (EphyPageRow, ephy_page_row, GTK_TYPE_LIST_BOX_ROW)
 
-static void
-sync_load_status (EphyWebView *view,
-                  GParamSpec  *pspec,
-                  EphyPageRow *self)
-{
-  EphyEmbed *embed;
-
-  g_assert (EPHY_IS_WEB_VIEW (view));
-  g_assert (EPHY_IS_PAGE_ROW (self));
-
-  embed = EPHY_GET_EMBED_FROM_EPHY_WEB_VIEW (view);
-
-  g_assert (EPHY_IS_EMBED (embed));
-
-  if (ephy_web_view_is_loading (view) && !ephy_embed_has_load_pending (embed)) {
-    gtk_stack_set_visible_child (self->icon_stack, GTK_WIDGET (self->spinner));
-    gtk_spinner_start (GTK_SPINNER (self->spinner));
-  } else {
-    gtk_stack_set_visible_child (self->icon_stack, GTK_WIDGET (self->icon));
-    gtk_spinner_stop (GTK_SPINNER (self->spinner));
-  }
-}
-
-static void
-load_changed_cb (EphyWebView     *view,
-                 WebKitLoadEvent  load_event,
-                 EphyPageRow     *self)
-{
-  sync_load_status (view, NULL, self);
-}
-
 static void
 close_clicked_cb (EphyPageRow *self)
 {
@@ -134,38 +103,11 @@ ephy_page_row_init (EphyPageRow *self)
   gtk_widget_init_template (GTK_WIDGET (self));
 }
 
-static void
-sync_favicon (EphyWebView *view,
-              GParamSpec  *pspec,
-              EphyPageRow *self)
-{
-  g_autoptr (GdkPixbuf) pixbuf = NULL;
-
-  if (ephy_web_view_get_icon (view))
-    pixbuf = gdk_pixbuf_copy (ephy_web_view_get_icon (view));
-
-  if (pixbuf) {
-    cairo_surface_t *surface;
-
-    surface = gdk_cairo_surface_create_from_pixbuf (pixbuf,
-                                                    0,
-                                                    gtk_widget_get_window (GTK_WIDGET (view)));
-    gtk_image_set_from_surface (GTK_IMAGE (self->icon), surface);
-    cairo_surface_destroy (surface);
-  } else {
-    const char *favicon_name = ephy_get_fallback_favicon_name (ephy_web_view_get_display_address (view), 
EPHY_FAVICON_TYPE_SHOW_MISSING_PLACEHOLDER);
-
-    gtk_image_set_from_icon_name (GTK_IMAGE (self->icon), favicon_name, GTK_ICON_SIZE_MENU);
-  }
-}
-
 EphyPageRow *
 ephy_page_row_new (HdyTabPage *page)
 {
   EphyPageRow *self;
   GtkWidget *embed;
-//  GtkWidget *tab_label;
-//  EphyWebView *view;
 
   g_assert (HDY_IS_TAB_PAGE (page));
 
@@ -175,20 +117,7 @@ ephy_page_row_new (HdyTabPage *page)
   embed = hdy_tab_page_get_content (page);
 
   g_assert (EPHY_IS_EMBED (embed));
-/*
-  tab_label = gtk_notebook_get_tab_label (GTK_NOTEBOOK (notebook), embed);
-  view = ephy_embed_get_web_view (EPHY_EMBED (embed));
-
-  sync_favicon (view, NULL, self);
-  g_signal_connect_object (view, "notify::icon", G_CALLBACK (sync_favicon), self, 0);
-  g_object_bind_property (embed, "title", self->title, "label", G_BINDING_SYNC_CREATE);
-  g_object_bind_property (embed, "title", self->title, "tooltip-text", G_BINDING_SYNC_CREATE);
-  g_object_bind_property (view, "is-playing-audio", self->speaker_icon, "visible", G_BINDING_SYNC_CREATE);
-  g_object_bind_property (tab_label, "pinned", self->close_button, "visible", G_BINDING_SYNC_CREATE | 
G_BINDING_INVERT_BOOLEAN);
-  sync_load_status (view, NULL, self);
-  g_signal_connect_object (view, "load-changed",
-                           G_CALLBACK (load_changed_cb), self, 0);
-*/
+
   return self;
 }
 
diff --git a/src/ephy-session.c b/src/ephy-session.c
index 4ac82f507..3abf54556 100644
--- a/src/ephy-session.c
+++ b/src/ephy-session.c
@@ -1256,8 +1256,6 @@ session_parse_embed (SessionParserContext  *context,
                                      context->window, NULL, flags,
                                      0);
 
-    // TODO this is not good, we should use insert_pinned() instead, as pinning
-    // causes a reordering
     hdy_tab_view_set_page_pinned (tab_view,
                                   hdy_tab_view_get_page (tab_view, GTK_WIDGET (embed)),
                                   is_pin);
diff --git a/src/ephy-tab-view.c b/src/ephy-tab-view.c
index 37dfb4ff6..bdcccc78c 100644
--- a/src/ephy-tab-view.c
+++ b/src/ephy-tab-view.c
@@ -105,27 +105,12 @@ ephy_tab_view_get_property (GObject    *object,
   }
 }
 
-static void
-ephy_tab_view_set_property (GObject      *object,
-                            guint         prop_id,
-                            const GValue *value,
-                            GParamSpec   *pspec)
-{
-  EphyTabView *self = EPHY_TAB_VIEW (object);
-
-  switch (prop_id) {
-    default:
-      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
-  }
-}
-
 static void
 ephy_tab_view_class_init (EphyTabViewClass *klass)
 {
   GObjectClass *object_class = G_OBJECT_CLASS (klass);
 
   object_class->get_property = ephy_tab_view_get_property;
-  object_class->set_property = ephy_tab_view_set_property;
 
   properties[PROP_N_PAGES] =
     g_param_spec_int ("n-pages",
diff --git a/src/ephy-window.c b/src/ephy-window.c
index b7b4290a5..2e2b9ab8d 100644
--- a/src/ephy-window.c
+++ b/src/ephy-window.c
@@ -3160,10 +3160,6 @@ setup_tab_view (EphyWindow *window)
                            window,
                            G_CONNECT_SWAPPED);
 
-/*
-  g_signal_connect_swapped (notebook, "open-link",
-                            G_CALLBACK (ephy_link_open), window);
-*/
   return tab_view;
 }