[gnome-shell/zbrown/search-change: 2/2] remoteSearch: Fetch enabled/disabled list once

[Marge Bot <marge-bot src gnome org>]

commit 2f70e524c33db55a3c33c0a4bb02eaee093d8454
Author: Zander Brown <zbrown gnome org>
Date:   Fri Apr 2 04:39:31 2021 +0100

    remoteSearch: Fetch enabled/disabled list once
    
    GLib should be caching the values but it seems unnecessary to fetch
    and marshal what should be the same lists N times instead of just once
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1791>

 js/ui/remoteSearch.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/js/ui/remoteSearch.js b/js/ui/remoteSearch.js
index 77ad317e1e..137516bdcb 100644
--- a/js/ui/remoteSearch.js
+++ b/js/ui/remoteSearch.js
@@ -142,16 +142,16 @@ function loadRemoteSearchProviders(searchSettings, callback) {
     // Special case gnome-control-center to be always active and always first
     sortOrder.unshift('gnome-control-center.desktop');
 
+    const disabled = searchSettings.get_strv('disabled');
+    const enabled = searchSettings.get_strv('enabled');
+
     loadedProviders = loadedProviders.filter(provider => {
         let appId = provider.appInfo.get_id();
 
-        if (provider.defaultEnabled) {
-            let disabled = searchSettings.get_strv('disabled');
+        if (provider.defaultEnabled)
             return !disabled.includes(appId);
-        } else {
-            let enabled = searchSettings.get_strv('enabled');
+        else
             return enabled.includes(appId);
-        }
     });
 
     loadedProviders.sort((providerA, providerB) => {