[gnome-shell/gnome-3-38] gdm: Ensure we cancel all the previously running services on auth retry



commit d811626605d806ec5398fe93e61f90349ee87f79
Author: Marco Trevisan (TreviƱo) <mail 3v1n0 net>
Date:   Tue Feb 2 17:29:29 2021 +0100

    gdm: Ensure we cancel all the previously running services on auth retry
    
    When retrying the authentication we should make sure that all the
    previously initiated services are stopped in order to begin a new
    authentication session with all the configured services.
    
    Unfortunately at the current state we only dispose the currently used
    user verifier, but we don't make it to stop all the relative gdm workers
    and then they'll stay around potentially blocking any further usage of
    them (as it happens with the fingerprint one, that has unique access to
    the device).
    
    So, cancel the currently running authentication before starting a new
    one if we're explicitly retrying.
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1783>

 js/gdm/util.js | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/js/gdm/util.js b/js/gdm/util.js
index 325bcb5642..5d5418bdba 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -537,6 +537,7 @@ var ShellUserVerifier = class {
     }
 
     _retry() {
+        this.cancel();
         this.begin(this._userName, new Batch.Hold());
     }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]