[gnome-initial-setup/wip/sadiq/fix-memory-leak: 2/2] common-language: Fix a memory leak
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [gnome-initial-setup/wip/sadiq/fix-memory-leak: 2/2] common-language: Fix a memory leak
- Date: Mon, 12 Apr 2021 19:31:36 +0000 (UTC)
commit a2157368868d0e8e7a8cb0825c78ba88200052e7
Author: Mohammed Sadiq <sadiq sadiqpk org>
Date:   Fri Apr 2 16:17:45 2021 +0530
    common-language: Fix a memory leak
    
    The string was not freed when it was inserted to the hashtable
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-initial-setup/-/merge_requests/118>
 gnome-initial-setup/cc-common-language.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
---
diff --git a/gnome-initial-setup/cc-common-language.c b/gnome-initial-setup/cc-common-language.c
index 0aba41f8..16dd28fb 100644
--- a/gnome-initial-setup/cc-common-language.c
+++ b/gnome-initial-setup/cc-common-language.c
@@ -274,7 +274,7 @@ insert_language (GHashTable *ht,
 static void
 insert_user_languages (GHashTable *ht)
 {
-        char *name;
+        g_autofree char *name = NULL;
 
         /* Add the languages used by other users on the system */
         add_other_users_language (ht);
@@ -283,8 +283,6 @@ insert_user_languages (GHashTable *ht)
         name = cc_common_language_get_current_language ();
         if (g_hash_table_lookup (ht, name) == NULL) {
                 insert_language (ht, name);
-        } else {
-                g_free (name);
         }
 }
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]