[gdm/rhel-7.9: 27/51] session: Don't leak remote greeter interface




commit 9a0f9b0165463cc11918751be2bf4d6a52091fbc
Author: Ray Strode <rstrode redhat com>
Date:   Tue Sep 15 00:41:00 2020 -0400

    session: Don't leak remote greeter interface
    
    XDMCP login screens get a "Remote Geeter Interface" exported over
    the bus connection (so the login window can provide a Disconnect
    button).
    
    This interface is getting leaked when the session object is disposed,
    leaving the bus connection itself undisposed, which causes an fd
    leak.
    
    This commit plugs the interface leak, and thus the fd leak.

 daemon/gdm-session.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/daemon/gdm-session.c b/daemon/gdm-session.c
index 35a530edf..2f848a5e7 100644
--- a/daemon/gdm-session.c
+++ b/daemon/gdm-session.c
@@ -3427,6 +3427,7 @@ gdm_session_dispose (GObject *object)
         g_clear_pointer (&self->priv->user_verifier_extensions,
                          g_hash_table_unref);
         g_clear_object (&self->priv->greeter_interface);
+        g_clear_object (&self->priv->remote_greeter_interface);
         g_clear_object (&self->priv->chooser_interface);
 
         g_free (self->priv->display_name);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]