[evolution-ews/gnome-40] PrintableOptions.cmake: Correct variable name comparison
- From: Milan Crha <mcrha src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [evolution-ews/gnome-40] PrintableOptions.cmake: Correct variable name comparison
 
- Date: Mon, 19 Apr 2021 15:06:18 +0000 (UTC)
 
commit 8e98b9686f02734e4a796c7615af95e7b725abc1
Author: Milan Crha <mcrha redhat com>
Date:   Wed Apr 14 16:58:08 2021 +0200
    PrintableOptions.cmake: Correct variable name comparison
    
    CMake 3.20.1 errors out with:
    
    CMake Error at cmake/modules/PrintableOptions.cmake:38 (message):
       variable name cannot be empty
     Call Stack (most recent call first):
       CMakeLists.txt:152 (add_printable_variable)
    
    Change how the parameter value is compared, to fix it.
 cmake/modules/PrintableOptions.cmake | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
---
diff --git a/cmake/modules/PrintableOptions.cmake b/cmake/modules/PrintableOptions.cmake
index ba1c9d0b..339f1da4 100644
--- a/cmake/modules/PrintableOptions.cmake
+++ b/cmake/modules/PrintableOptions.cmake
@@ -19,40 +19,40 @@
 #    prints all the build options previously added with the above functions
 
 macro(add_printable_variable_bare _name)
-       if(_name STREQUAL "")
+       if("${_name}" STREQUAL "")
                message(FATAL_ERROR "variable name cannot be empty")
-       endif(_name STREQUAL "")
+       endif("${_name}" STREQUAL "")
        list(APPEND _printable_options ${_name})
 endmacro()
 
 macro(add_printable_option _name _description _default_value)
-       if(_name STREQUAL "")
+       if("${_name}" STREQUAL "")
                message(FATAL_ERROR "option name cannot be empty")
-       endif(_name STREQUAL "")
+       endif("${_name}" STREQUAL "")
        option(${_name} ${_description} ${_default_value})
        add_printable_variable_bare(${_name})
 endmacro()
 
 macro(add_printable_variable _name _description _default_value)
-       if(_name STREQUAL "")
+       if("${_name}" STREQUAL "")
                message(FATAL_ERROR "variable name cannot be empty")
-       endif(_name STREQUAL "")
+       endif("${_name}" STREQUAL "")
        set(${_name} ${_default_value} CACHE STRING ${_description})
        add_printable_variable_bare(${_name})
 endmacro()
 
 macro(add_printable_variable_path _name _description _default_value)
-       if(_name STREQUAL "")
+       if("${_name}" STREQUAL "")
                message(FATAL_ERROR "path variable name cannot be empty")
-       endif(_name STREQUAL "")
+       endif("${_name}" STREQUAL "")
        set(${_name} ${_default_value} CACHE PATH ${_description})
        add_printable_variable_bare(${_name})
 endmacro()
 
 macro(add_printable_variable_filepath _name _description _default_value)
-       if(_name STREQUAL "")
+       if("${_name}" STREQUAL "")
                message(FATAL_ERROR "filepath variable name cannot be empty")
-       endif(_name STREQUAL "")
+       endif("${_name}" STREQUAL "")
        set(${_name} ${_default_value} CACHE FILEPATH ${_description})
        add_printable_variable_bare(${_name})
 endmacro()
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]