[vala/staging: 1/2] codegen: Emit external creation methods in bindings
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala/staging: 1/2] codegen: Emit external creation methods in bindings
- Date: Mon, 19 Apr 2021 18:59:19 +0000 (UTC)
commit a29919c122efec0b25217c6ee2e94b3771d7e7b6
Author: Rico Tzschichholz <ricotz ubuntu com>
Date: Wed Apr 7 18:14:16 2021 +0200
codegen: Emit external creation methods in bindings
These must be chained up to an existing constructor of the parent symbol
codegen/valaccodebasemodule.vala | 18 ++++++++++++++++++
codegen/valaccodemethodmodule.vala | 2 +-
2 files changed, 19 insertions(+), 1 deletion(-)
---
diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 415522c42..0e35f449d 100644
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -4905,6 +4905,24 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
generate_method_declaration (m, cfile);
+ if (m is CreationMethod && !m.external && m.external_package) {
+ unowned CreationMethod cm = (CreationMethod) m;
+ if (!cm.chain_up) {
+ Report.error (cm.source_reference, "internal: Creation method
implementation in binding must be chained up");
+ }
+ // internal VAPI creation methods
+ // only add them once per source file
+ if (add_generated_external_symbol (cm)) {
+ // temporarily disable since-check and rely on the version attribute
of this method
+ var old_since_check = context.since_check;
+ context.since_check = false;
+
+ visit_creation_method (cm);
+
+ context.since_check = old_since_check;
+ }
+ }
+
unowned Class? cl = expr.type_reference.type_symbol as Class;
if (!get_ccode_has_new_function (m)) {
diff --git a/codegen/valaccodemethodmodule.vala b/codegen/valaccodemethodmodule.vala
index df3b8b274..83a248e01 100644
--- a/codegen/valaccodemethodmodule.vala
+++ b/codegen/valaccodemethodmodule.vala
@@ -1232,7 +1232,7 @@ public abstract class Vala.CCodeMethodModule : CCodeStructModule {
visit_method (m);
ellipses_to_valist = false;
- if (m.source_type == SourceFileType.FAST) {
+ if ((!m.external && m.external_package) || m.source_type == SourceFileType.FAST) {
pop_line ();
return;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]