[gnome-software/wip/mcrha/sources-combo-hid] gs-details-page: Origin/source picker sometimes hidden

[Milan Crha <mcrha src gnome org>]

commit 3a6497423091d7c51417f9b006279a33e30136b2
Author: Milan Crha <mcrha redhat com>
Date:   Fri Aug 6 12:48:45 2021 +0200

    gs-details-page: Origin/source picker sometimes hidden
    
    There could be sometimes hid the origin/Source picker in error, when
    the set app changes its state, which called, on idle, the switch_to(),
    where the picker is hid. The switch_to() doesn't make sense there,
    because the page is already selected, thus rather only refresh
    the page content.

 src/gs-details-page.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 39d4e4bef..f83b97bce 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -520,14 +520,11 @@ gs_details_page_allow_cancel_changed_cb (GsApp *app,
 }
 
 static gboolean
-gs_details_page_switch_to_idle (gpointer user_data)
+gs_details_page_refresh_idle (gpointer user_data)
 {
        GsDetailsPage *self = GS_DETAILS_PAGE (user_data);
 
        if (gs_shell_get_mode (self->shell) == GS_SHELL_MODE_DETAILS) {
-               gs_page_switch_to (GS_PAGE (self));
-               gs_page_scroll_up (GS_PAGE (self));
-
                /* update widgets */
                gs_details_page_refresh_all (self);
        }
@@ -541,7 +538,7 @@ gs_details_page_notify_state_changed_cb (GsApp *app,
                                          GParamSpec *pspec,
                                          GsDetailsPage *self)
 {
-       g_idle_add (gs_details_page_switch_to_idle, g_object_ref (self));
+       g_idle_add (gs_details_page_refresh_idle, g_object_ref (self));
 }
 
 static void