[gnome-software: 1/2] gs-details-page: Fix links not being updated
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 1/2] gs-details-page: Fix links not being updated
- Date: Mon, 9 Aug 2021 07:04:26 +0000 (UTC)
commit 06bc6c28eea7fb2bc240ed83d0c680e36b12645f
Author: Philip Withnall <pwithnall endlessos org>
Date: Fri Aug 6 18:34:01 2021 +0100
gs-details-page: Fix links not being updated
I broke this in a later review cycle on 310158cd and didn’t notice.
The logic was short-circuiting calls to `update_action_row_from_link()`,
so no links after the first one to be shown would be updated.
Spotted by Allan Day in
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1111#note_1243062.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
src/gs-details-page.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index ef220e9f1..810a2ec52 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -1044,11 +1044,11 @@ gs_details_page_refresh_all (GsDetailsPage *self)
/* Set various external links. If none are visible, show a fallback
* message instead. */
link_rows_visible = FALSE;
- link_rows_visible = link_rows_visible || update_action_row_from_link (self->project_website_row,
self->app, AS_URL_KIND_HOMEPAGE);
- link_rows_visible = link_rows_visible || update_action_row_from_link (self->donate_row, self->app,
AS_URL_KIND_DONATION);
- link_rows_visible = link_rows_visible || update_action_row_from_link (self->translate_row, self->app,
AS_URL_KIND_TRANSLATE);
- link_rows_visible = link_rows_visible || update_action_row_from_link (self->report_an_issue_row,
self->app, AS_URL_KIND_BUGTRACKER);
- link_rows_visible = link_rows_visible || update_action_row_from_link (self->help_row, self->app,
AS_URL_KIND_HELP);
+ link_rows_visible = update_action_row_from_link (self->project_website_row, self->app,
AS_URL_KIND_HOMEPAGE) || link_rows_visible;
+ link_rows_visible = update_action_row_from_link (self->donate_row, self->app, AS_URL_KIND_DONATION)
|| link_rows_visible;
+ link_rows_visible = update_action_row_from_link (self->translate_row, self->app,
AS_URL_KIND_TRANSLATE) || link_rows_visible;
+ link_rows_visible = update_action_row_from_link (self->report_an_issue_row, self->app,
AS_URL_KIND_BUGTRACKER) || link_rows_visible;
+ link_rows_visible = update_action_row_from_link (self->help_row, self->app, AS_URL_KIND_HELP) ||
link_rows_visible;
gtk_stack_set_visible_child_name (self->links_stack, link_rows_visible ? "links" : "empty");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]