[gnome-software: 1/2] Polish the page sizes

From: Tobias Bernard <tbernard src gnome org>
To: commits-list gnome org
Cc:
Subject: [gnome-software: 1/2] Polish the page sizes
Date: Fri, 13 Aug 2021 10:47:53 +0000 (UTC)

commit 6aefed5d354aa76f957cb5882187bbf0f7fe5f39
Author: Adrien Plazas <kekun plazas laposte net>
Date:   Tue Aug 10 09:21:22 2021 +0200

    Polish the page sizes
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1322

 src/gs-category-page.ui  |  5 +++--
 src/gs-details-page.ui   | 24 ++++++++++++++++++++++++
 src/gs-extras-page.ui    |  2 ++
 src/gs-installed-page.ui |  2 ++
 src/gs-loading-page.ui   |  2 ++
 src/gs-moderate-page.ui  |  2 ++
 src/gs-overview-page.ui  |  1 +
 src/gs-search-page.ui    |  3 ++-
 src/gs-updates-page.ui   |  4 ++++
 9 files changed, 42 insertions(+), 3 deletions(-)
---
diff --git a/src/gs-category-page.ui b/src/gs-category-page.ui
index d46befaff..13e90a35a 100644
--- a/src/gs-category-page.ui
+++ b/src/gs-category-page.ui
@@ -15,8 +15,9 @@
             <child>
               <object class="HdyClamp">
                 <property name="visible">True</property>
-                <!-- This is 3*420 plus margins, paddings, CSS borders -->
-                <property name="maximum-size">1338</property>
+                <!-- We use the same sizes as the overview page. -->
+                <property name="maximum-size">1000</property>
+                <property name="tightening-threshold">600</property>
                 <child>
                   <object class="GtkBox">
                     <property name="visible">True</property>
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 6d85cb34f..d087bc311 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -73,6 +73,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -345,6 +347,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -387,6 +391,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -443,6 +449,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -457,6 +465,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -511,6 +521,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="label_webapp_warning" bind-property="visible" 
bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -533,6 +545,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_app_repo" 
bind-property="visible" bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -550,6 +564,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_app_norepo" 
bind-property="visible" bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -567,6 +583,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_package_baseos" 
bind-property="visible" bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -584,6 +602,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="infobar_details_repo" bind-property="visible" 
bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -602,6 +622,8 @@
                       <object class="HdyClamp">
                         <property name="visible">True</property>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
@@ -833,6 +855,8 @@
                       <object class="HdyClamp">
                         <property name="visible" bind-source="box_reviews" bind-property="visible" 
bind-flags="sync-create"/>
                         <property name="maximum-size">860</property>
+                        <!-- ~⅔ of the maximum size. -->
+                        <property name="tightening-threshold">576</property>
                         <property name="margin-start">12</property>
                         <property name="margin-end">12</property>
                         <child>
diff --git a/src/gs-extras-page.ui b/src/gs-extras-page.ui
index 0ade17eb2..3d9ada3e2 100644
--- a/src/gs-extras-page.ui
+++ b/src/gs-extras-page.ui
@@ -49,6 +49,8 @@
               <object class="HdyClamp">
                 <property name="visible">True</property>
                 <property name="maximum-size">860</property>
+                <!-- ~⅔ of the maximum size. -->
+                <property name="tightening-threshold">576</property>
                 <child>
                   <object class="GtkBox" id="box_results">
                     <property name="visible">True</property>
diff --git a/src/gs-installed-page.ui b/src/gs-installed-page.ui
index e46d0b1bd..7a1ea935e 100644
--- a/src/gs-installed-page.ui
+++ b/src/gs-installed-page.ui
@@ -42,6 +42,8 @@
                 <child>
                   <object class="HdyClamp">
                     <property name="visible">True</property>
+                    <property name="maximum-size">600</property>
+                    <property name="tightening-threshold">400</property>
                     <child>
                       <object class="GtkBox">
                         <property name="visible">True</property>
diff --git a/src/gs-loading-page.ui b/src/gs-loading-page.ui
index e68969f0b..be61d6f9a 100644
--- a/src/gs-loading-page.ui
+++ b/src/gs-loading-page.ui
@@ -15,6 +15,8 @@
         <child>
           <object class="HdyClamp">
             <property name="visible">True</property>
+            <!-- We explicitly want to use the default HdyClamp sizes here, as
+                 does HdyStatusPage. -->
             <child>
               <object class="GtkProgressBar" id="progressbar">
                 <property name="visible">True</property>
diff --git a/src/gs-moderate-page.ui b/src/gs-moderate-page.ui
index 784018118..65b81c1e2 100644
--- a/src/gs-moderate-page.ui
+++ b/src/gs-moderate-page.ui
@@ -40,6 +40,8 @@
                   <object class="HdyClamp">
                     <property name="visible">True</property>
                     <property name="maximum-size">860</property>
+                    <!-- ~⅔ of the maximum size. -->
+                    <property name="tightening-threshold">576</property>
                     <child>
                       <object class="GtkListBox" id="list_box_install">
                         <property name="visible">True</property>
diff --git a/src/gs-overview-page.ui b/src/gs-overview-page.ui
index 550010b28..95dc908b4 100644
--- a/src/gs-overview-page.ui
+++ b/src/gs-overview-page.ui
@@ -73,6 +73,7 @@
                     <child>
                       <object class="HdyClamp">
                         <property name="visible">True</property>
+                        <!-- We use the same sizes as the category page. -->
                         <property name="maximum-size">1000</property>
                         <property name="tightening-threshold">600</property>
                         <child>
diff --git a/src/gs-search-page.ui b/src/gs-search-page.ui
index e0f048242..3fbeebe37 100644
--- a/src/gs-search-page.ui
+++ b/src/gs-search-page.ui
@@ -56,7 +56,8 @@
               <object class="HdyClamp">
                 <property name="visible">True</property>
                 <property name="maximum-size">860</property>
-                <property name="tightening-threshold">860</property>
+                <!-- ~⅔ of the maximum size. -->
+                <property name="tightening-threshold">576</property>
                 <child>
                   <object class="GtkListBox" id="list_box_search">
                     <property name="visible">True</property>
diff --git a/src/gs-updates-page.ui b/src/gs-updates-page.ui
index 993b6ef30..515fdc443 100644
--- a/src/gs-updates-page.ui
+++ b/src/gs-updates-page.ui
@@ -69,6 +69,8 @@
               <object class="HdyClamp">
                 <property name="visible">True</property>
                 <property name="valign">center</property>
+                <!-- We explicitly want to use the default HdyClamp sizes here,
+                     as does HdyStatusPage. -->
                 <style>
                   <class name="status-page"/>
                 </style>
@@ -132,6 +134,8 @@
                 <child>
                   <object class="HdyClamp">
                     <property name="visible">True</property>
+                    <property name="maximum-size">600</property>
+                    <property name="tightening-threshold">400</property>
                     <child>
                       <object class="GtkBox" id="list_box_updates_box">
                         <property name="visible">True</property>
[Date Prev][Date Next] [Thread Prev][Thread Next] [Thread Index] [Date Index] [Author Index]