[gnome-software: 8/25] core: Drop desktop-categories plugin

[Philip Withnall <pwithnall src gnome org>]

commit 3cc5d5d1db5da121d299f68cb01695ba908fe17a
Author: Philip Withnall <pwithnall endlessos org>
Date:   Mon Feb 1 22:55:15 2021 +0000

    core: Drop desktop-categories plugin
    
    After the refactoring in the previous few commits, it’s now empty and
    redundant.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>

 contrib/gnome-software.spec.in              |  1 -
 plugins/core/gs-plugin-desktop-categories.c | 26 --------------------------
 plugins/core/meson.build                    | 13 -------------
 plugins/dummy/gs-self-test.c                |  1 -
 plugins/snap/gs-plugin-snap.c               |  1 -
 5 files changed, 42 deletions(-)
---
diff --git a/contrib/gnome-software.spec.in b/contrib/gnome-software.spec.in
index 95404afa3..c274b5585 100644
--- a/contrib/gnome-software.spec.in
+++ b/contrib/gnome-software.spec.in
@@ -150,7 +150,6 @@ desktop-file-validate %{buildroot}%{_datadir}/applications/*.desktop
 %{_datadir}/metainfo/org.gnome.Software.Plugin.Odrs.metainfo.xml
 %dir %{_libdir}/gs-plugins-%{gs_plugin_version}
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_appstream.so
-%{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_desktop-categories.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_desktop-menu-path.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_dummy.so
 %{_libdir}/gs-plugins-%{gs_plugin_version}/libgs_plugin_fedora-langpacks.so
diff --git a/plugins/core/meson.build b/plugins/core/meson.build
index 7ec23bccf..331ac2a33 100644
--- a/plugins/core/meson.build
+++ b/plugins/core/meson.build
@@ -98,19 +98,6 @@ shared_module(
   ],
 )
 
-shared_module(
-  'gs_plugin_desktop-categories',
-  sources : 'gs-plugin-desktop-categories.c',
-  include_directories : [
-    include_directories('../..'),
-    include_directories('../../lib'),
-  ],
-  install : true,
-  install_dir: plugin_dir,
-  c_args : cargs,
-  dependencies : plugin_libs,
-)
-
 shared_module(
   'gs_plugin_desktop-menu-path',
   sources : 'gs-plugin-desktop-menu-path.c',
diff --git a/plugins/dummy/gs-self-test.c b/plugins/dummy/gs-self-test.c
index bc8da5015..10748003c 100644
--- a/plugins/dummy/gs-self-test.c
+++ b/plugins/dummy/gs-self-test.c
@@ -724,7 +724,6 @@ main (int argc, char **argv)
                "dummy",
                "generic-updates",
                "hardcoded-blocklist",
-               "desktop-categories",
                "desktop-menu-path",
                "icons",
                "key-colors",
diff --git a/plugins/snap/gs-plugin-snap.c b/plugins/snap/gs-plugin-snap.c
index b24ed8442..ba08274af 100644
--- a/plugins/snap/gs-plugin-snap.c
+++ b/plugins/snap/gs-plugin-snap.c
@@ -128,7 +128,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        priv->store_snaps = g_hash_table_new_full (g_str_hash, g_str_equal,
                                                   g_free, (GDestroyNotify) cache_entry_free);
 
-       gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_AFTER, "desktop-categories");
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_BETTER_THAN, "packagekit");
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_RUN_BEFORE, "icons");