[gupnp] Unbreak dLeyna shutdown



commit 1a133912d863365b060c4ca76ebb49eef278182b
Author: Jens Georg <mail jensge org>
Date:   Sat Jun 5 09:37:01 2021 +0200

    Unbreak dLeyna shutdown
    
    This broke managed control points by not releasing the CP when the
    context manger loses its last reference, causing the
    available/unavailable callbacks being triggered on potentially freed
    objects
    
    More investigation needs to be done why this fix was needed
    
    Revert "control-point: Hold a ref on control point while async downloading"
    
    This reverts commit 4a68246fe21df78bd1c3a0460d2d1eaaaf5747f7.

 libgupnp/gupnp-control-point.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
---
diff --git a/libgupnp/gupnp-control-point.c b/libgupnp/gupnp-control-point.c
index 5f94aa0..6a59fb0 100644
--- a/libgupnp/gupnp-control-point.c
+++ b/libgupnp/gupnp-control-point.c
@@ -116,7 +116,6 @@ get_description_url_data_free (GetDescriptionURLData *data)
         g_free (data->udn);
         g_free (data->service_type);
         g_free (data->description_url);
-        g_object_unref (data->control_point);
 
         g_slice_free (GetDescriptionURLData, data);
 }
@@ -738,7 +737,7 @@ load_description (GUPnPControlPoint *control_point,
 
                 http_request_set_accept_language (data->message);
 
-                data->control_point   = g_object_ref (control_point);
+                data->control_point   = control_point;
 
                 data->udn             = g_strdup (udn);
                 data->service_type    = g_strdup (service_type);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]