[gnome-software: 15/18] gs-details-page: Drop the app category details

[Philip Withnall <pwithnall src gnome org>]

commit 7e681fd6bf4ce972c837c9a88423d52209f0a5e7
Author: Philip Withnall <pwithnall endlessos org>
Date:   Fri May 28 15:04:34 2021 +0100

    gs-details-page: Drop the app category details
    
    There’s no replacement for this; it’s just not very useful to show, and
    doesn’t appear in the new designs at
    https://gitlab.gnome.org/Teams/Design/software-mockups/-/raw/master/adaptive/app-page-adaptive.png.
    
    Signed-off-by: Philip Withnall <pwithnall endlessos org>
    
    Helps: #1111

 src/gs-details-page.c  | 21 ---------------------
 src/gs-details-page.ui | 36 ------------------------------------
 2 files changed, 57 deletions(-)
---
diff --git a/src/gs-details-page.c b/src/gs-details-page.c
index 884a407ff..cfc8902e4 100644
--- a/src/gs-details-page.c
+++ b/src/gs-details-page.c
@@ -110,8 +110,6 @@ struct _GsDetailsPage
        GtkWidget               *label_progress_status;
        GtkWidget               *label_addons_uninstalled_app;
        GsAppContextBar         *context_bar;
-       GtkWidget               *label_details_category_title;
-       GtkWidget               *label_details_category_value;
        GtkWidget               *label_details_developer_title;
        GtkWidget               *label_details_developer_value;
        GtkWidget               *box_details_developer;
@@ -937,7 +935,6 @@ gs_details_page_refresh_all (GsDetailsPage *self)
        GList *addons;
        const gchar *tmp;
        gboolean ret;
-       gchar **menu_path;
        guint64 kudos;
        guint64 updated;
        guint64 user_integration_bf;
@@ -1086,22 +1083,6 @@ gs_details_page_refresh_all (GsDetailsPage *self)
                gtk_widget_set_visible (self->label_details_updated_value, TRUE);
        }
 
-       /* set the category */
-       menu_path = gs_app_get_menu_path (self->app);
-       if (menu_path == NULL || menu_path[0] == NULL || menu_path[0][0] == '\0') {
-               gtk_widget_set_visible (self->label_details_category_title, FALSE);
-               gtk_widget_set_visible (self->label_details_category_value, FALSE);
-       } else {
-               g_autofree gchar *path = NULL;
-               if (gtk_widget_get_direction (self->label_details_category_value) == GTK_TEXT_DIR_RTL)
-                       path = g_strjoinv (" ← ", menu_path);
-               else
-                       path = g_strjoinv (" → ", menu_path);
-               gtk_label_set_label (GTK_LABEL (self->label_details_category_value), path);
-               gtk_widget_set_visible (self->label_details_category_title, TRUE);
-               gtk_widget_set_visible (self->label_details_category_value, TRUE);
-       }
-
        /* set the origin */
        origin = g_strdup (gs_app_get_origin_hostname (self->app));
        if (origin == NULL)
@@ -2309,8 +2290,6 @@ gs_details_page_class_init (GsDetailsPageClass *klass)
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, context_bar);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_progress_percentage);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_progress_status);
-       gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_category_title);
-       gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_category_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_developer_title);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, label_details_developer_value);
        gtk_widget_class_bind_template_child (widget_class, GsDetailsPage, box_details_developer);
diff --git a/src/gs-details-page.ui b/src/gs-details-page.ui
index 768f5ce73..d798bbc2a 100644
--- a/src/gs-details-page.ui
+++ b/src/gs-details-page.ui
@@ -816,42 +816,6 @@
                                     <property name="top_attach">3</property>
                                   </packing>
                                 </child>
-                                <child>
-                                  <object class="GtkLabel" id="label_details_category_title">
-                                    <property name="visible">True</property>
-                                    <property name="label" translatable="yes">Category</property>
-                                    <property name="xalign">0</property>
-                                    <property name="yalign">0.5</property>
-                                    <property name="vexpand">True</property>
-                                    <style>
-                                      <class name="dim-label"/>
-                                    </style>
-                                  </object>
-                                  <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">4</property>
-                                  </packing>
-                                </child>
-                                <child>
-                                  <object class="GtkLabel" id="label_details_category_value">
-                                    <property name="visible">True</property>
-                                    <property name="can_focus">True</property>
-                                    <property name="hexpand">True</property>
-                                    <property name="label">Photos &amp; Video</property>
-                                    <property name="wrap">True</property>
-                                    <property name="selectable">True</property>
-                                    <property name="max_width_chars">10</property>
-                                    <property name="xalign">0</property>
-                                    <property name="yalign">0.5</property>
-                                    <accessibility>
-                                      <relation type="labelled-by" target="label_details_category_title"/>
-                                    </accessibility>
-                                  </object>
-                                  <packing>
-                                    <property name="left_attach">1</property>
-                                    <property name="top_attach">4</property>
-                                  </packing>
-                                </child>
 
                                 <child>
                                   <object class="GtkLabel" id="label_details_origin_title">