[seahorse] hkp: Fix strncpy compiler warning
- From: Niels De Graef <nielsdg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [seahorse] hkp: Fix strncpy compiler warning
- Date: Thu, 4 Mar 2021 21:31:19 +0000 (UTC)
commit 6fd719ef9947f72a69dbfb7c0b1b075dc20a076d
Author: Niels De Graef <nielsdegraef gmail com>
Date: Thu Mar 4 22:29:35 2021 +0100
hkp: Fix strncpy compiler warning
The strncpy is meant to copy the zero-terminator, but apparently gcc
thinks we might be wrong, so let's just be explicit about it and make
the compiler happy.
pgp/seahorse-hkp-source.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
---
diff --git a/pgp/seahorse-hkp-source.c b/pgp/seahorse-hkp-source.c
index 73f9e09e..1ccf5fb5 100644
--- a/pgp/seahorse-hkp-source.c
+++ b/pgp/seahorse-hkp-source.c
@@ -877,8 +877,7 @@ seahorse_hkp_source_export_async (SeahorseServerSource *source,
g_autoptr(GTask) task = NULL;
SoupURI *uri;
g_autoptr(GHashTable) form = NULL;
- gchar hexfpr[11];
- gint i;
+ char hexfpr[11];
task = g_task_new (self, cancellable, callback, user_data);
closure = g_new0 (ExportClosure, 1);
@@ -900,8 +899,8 @@ seahorse_hkp_source_export_async (SeahorseServerSource *source,
strncpy (hexfpr, "0x", 3);
form = g_hash_table_new (g_str_hash, g_str_equal);
- for (i = 0; keyids[i] != NULL; i++) {
- const gchar *fpr = keyids[i];
+ for (int i = 0; keyids[i] != NULL; i++) {
+ const char *fpr = keyids[i];
guint len;
SoupMessage *message;
@@ -912,7 +911,8 @@ seahorse_hkp_source_export_async (SeahorseServerSource *source,
if (len > 8)
fpr += (len - 8);
- strncpy (hexfpr + 2, fpr, 9);
+ strncpy (hexfpr + 2, fpr, 8);
+ hexfpr[10] = '\0';
/* The get key URI */
g_hash_table_insert (form, "op", "get");
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]