[gnome-shell] keyboard: Handle symbolic OSK key codes as explicitly invalid
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] keyboard: Handle symbolic OSK key codes as explicitly invalid
- Date: Mon, 15 Mar 2021 12:46:34 +0000 (UTC)
commit 1f0e4b58ab1af96840475896e2fe9409468b5be0
Author: Daniel van Vugt <daniel van vugt canonical com>
Date: Fri Mar 12 14:45:19 2021 +0800
keyboard: Handle symbolic OSK key codes as explicitly invalid
`key` is an empty string in this case, causing `charCodeAt(0)` to return
`NaN`, which when passed to `Clutter.unicode_to_keysym` now generates an
error in gjs >= 1.67.3:
```
JS ERROR: Error: Argument wc: value is out of range for uint32
```
And the symbolic keys like Backspace, Enter and Caps Lock would have their
presses ignored.
Just skip the call to `charCodeAt` that will fail and allow
`Clutter.unicode_to_keysym` to return its usual error flag.
Fixes: https://bugs.launchpad.net/bugs/1918738
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1758>
js/ui/keyboard.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/keyboard.js b/js/ui/keyboard.js
index 7452feaac5..866382e4fe 100644
--- a/js/ui/keyboard.js
+++ b/js/ui/keyboard.js
@@ -327,7 +327,7 @@ var Key = GObject.registerClass({
}
_getKeyval(key) {
- let unicode = key.charCodeAt(0);
+ let unicode = key.length ? key.charCodeAt(0) : undefined;
return Clutter.unicode_to_keysym(unicode);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]