[gtk/matthiasc/for-master: 4/6] sizerequest: Avoid a corner case
- From: Matthias Clasen <matthiasc src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [gtk/matthiasc/for-master: 4/6] sizerequest: Avoid a corner case
 
- Date: Wed, 17 Mar 2021 11:58:25 +0000 (UTC)
 
commit 8b82993dde5bea985dac69e5ff940236db11f83b
Author: Matthias Clasen <mclasen redhat com>
Date:   Wed Mar 17 07:50:24 2021 -0400
    sizerequest: Avoid a corner case
    
    gcc 11 warns that the code isn't safe when
    n_requested_sizes is 0. Add a precondition check
    to make it clear that that never happens.
 gtk/gtksizerequest.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/gtk/gtksizerequest.c b/gtk/gtksizerequest.c
index a8d4ff7763..bad631c022 100644
--- a/gtk/gtksizerequest.c
+++ b/gtk/gtksizerequest.c
@@ -698,6 +698,7 @@ gtk_distribute_natural_allocation (int               extra_space,
   int    i;
 
   g_return_val_if_fail (extra_space >= 0, 0);
+  g_return_val_if_fail (n_requested_sizes > 0, 0);
 
   spreading = g_newa (guint, n_requested_sizes);
 
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]