[gnome-todo] task-list-view: Remove behavior selector API

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit 2ef08f66aae7d8a6396196277ac97de62c324eb6
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Fri May 7 18:28:27 2021 -0300

    task-list-view: Remove behavior selector API
    
    Nasty API, more than happy to drop it.

 src/gui/gtd-task-list-view.c              | 53 -------------------------------
 src/gui/gtd-task-list-view.h              | 13 --------
 src/plugins/inbox-panel/gtd-inbox-panel.c |  2 --
 3 files changed, 68 deletions(-)
---
diff --git a/src/gui/gtd-task-list-view.c b/src/gui/gtd-task-list-view.c
index 2b99bfe5..88debff8 100644
--- a/src/gui/gtd-task-list-view.c
+++ b/src/gui/gtd-task-list-view.c
@@ -111,7 +111,6 @@ typedef struct
   GtdTaskRow             *active_row;
   GtkSizeGroup           *due_date_sizegroup;
   GtkSizeGroup           *tasklist_name_sizegroup;
-  GtdTaskListSelectorBehavior task_list_selector_behavior;
 } GtdTaskListViewPrivate;
 
 struct _GtdTaskListView
@@ -1121,8 +1120,6 @@ gtd_task_list_view_init (GtdTaskListView *self)
   priv = gtd_task_list_view_get_instance_private (self);
 
   self->priv = priv;
-
-  priv->task_list_selector_behavior = GTD_TASK_LIST_SELECTOR_BEHAVIOR_AUTOMATIC;
   priv->task_to_row = g_hash_table_new (NULL, NULL);
 
   priv->can_toggle = TRUE;
@@ -1236,9 +1233,6 @@ gtd_task_list_view_set_model (GtdTaskListView *view,
   schedule_scroll_to_bottom (view);
   update_incomplete_tasks_model (view);
   update_empty_state (view);
-
-  if (priv->task_list_selector_behavior == GTD_TASK_LIST_SELECTOR_BEHAVIOR_AUTOMATIC)
-    gtd_new_task_row_set_show_list_selector (GTD_NEW_TASK_ROW (priv->new_task_row), !GTD_IS_TASK_LIST 
(model));
 }
 
 /**
@@ -1434,50 +1428,3 @@ gtd_task_list_view_set_default_date   (GtdTaskListView *self,
   g_clear_pointer (&priv->default_date, g_date_time_unref);
   priv->default_date = default_date ? g_date_time_ref (default_date) : NULL;
 }
-
-GtdTaskListSelectorBehavior
-gtd_task_list_view_get_task_list_selector_behavior (GtdTaskListView *self)
-{
-  GtdTaskListViewPrivate *priv;
-
-  g_return_val_if_fail (GTD_IS_TASK_LIST_VIEW (self), -1);
-
-  priv = gtd_task_list_view_get_instance_private (self);
-
-  return priv->task_list_selector_behavior;
-}
-
-void
-gtd_task_list_view_set_task_list_selector_behavior (GtdTaskListView             *self,
-                                                    GtdTaskListSelectorBehavior  behavior)
-{
-  GtdTaskListViewPrivate *priv;
-
-  g_return_if_fail (GTD_IS_TASK_LIST_VIEW (self));
-
-  priv = gtd_task_list_view_get_instance_private (self);
-
-  if (priv->task_list_selector_behavior == behavior)
-    return;
-
-  priv->task_list_selector_behavior = behavior;
-
-  switch (behavior)
-    {
-    case GTD_TASK_LIST_SELECTOR_BEHAVIOR_AUTOMATIC:
-      if (priv->model)
-        {
-          gtd_new_task_row_set_show_list_selector (GTD_NEW_TASK_ROW (priv->new_task_row),
-                                                   !GTD_IS_TASK_LIST (priv->model));
-        }
-      break;
-
-    case GTD_TASK_LIST_SELECTOR_BEHAVIOR_ALWAYS_SHOW:
-      gtd_new_task_row_set_show_list_selector (GTD_NEW_TASK_ROW (priv->new_task_row), TRUE);
-      break;
-
-    case GTD_TASK_LIST_SELECTOR_BEHAVIOR_ALWAYS_HIDE:
-      gtd_new_task_row_set_show_list_selector (GTD_NEW_TASK_ROW (priv->new_task_row), FALSE);
-      break;
-    }
-}
diff --git a/src/gui/gtd-task-list-view.h b/src/gui/gtd-task-list-view.h
index 7258a20e..6ec237ab 100644
--- a/src/gui/gtd-task-list-view.h
+++ b/src/gui/gtd-task-list-view.h
@@ -26,16 +26,8 @@
 G_BEGIN_DECLS
 
 #define GTD_TYPE_TASK_LIST_VIEW (gtd_task_list_view_get_type())
-
 G_DECLARE_FINAL_TYPE (GtdTaskListView, gtd_task_list_view, GTD, TASK_LIST_VIEW, GtkBox)
 
-typedef enum
-{
-  GTD_TASK_LIST_SELECTOR_BEHAVIOR_AUTOMATIC,
-  GTD_TASK_LIST_SELECTOR_BEHAVIOR_ALWAYS_SHOW,
-  GTD_TASK_LIST_SELECTOR_BEHAVIOR_ALWAYS_HIDE,
-} GtdTaskListSelectorBehavior;
-
 /**
  * GtdTaskListViewHeaderFunc:
  * @task: the #GtdTask that @row represents
@@ -81,11 +73,6 @@ GDateTime*                gtd_task_list_view_get_default_date   (GtdTaskListView
 void                      gtd_task_list_view_set_default_date   (GtdTaskListView        *self,
                                                                  GDateTime              *default_date);
 
-GtdTaskListSelectorBehavior gtd_task_list_view_get_task_list_selector_behavior (GtdTaskListView             
*self);
-
-void                        gtd_task_list_view_set_task_list_selector_behavior (GtdTaskListView             
*self,
-                                                                                GtdTaskListSelectorBehavior  
behavior);
-
 G_END_DECLS
 
 #endif /* GTD_TASK_LIST_VIEW_H */
diff --git a/src/plugins/inbox-panel/gtd-inbox-panel.c b/src/plugins/inbox-panel/gtd-inbox-panel.c
index 496ee060..8b4fd9a6 100644
--- a/src/plugins/inbox-panel/gtd-inbox-panel.c
+++ b/src/plugins/inbox-panel/gtd-inbox-panel.c
@@ -253,8 +253,6 @@ gtd_inbox_panel_init (GtdInboxPanel *self)
   gtd_task_list_view_set_model (GTD_TASK_LIST_VIEW (self->view), G_LIST_MODEL (self->filter_model));
   gtd_task_list_view_set_show_list_name (GTD_TASK_LIST_VIEW (self->view), FALSE);
   gtd_task_list_view_set_show_due_date (GTD_TASK_LIST_VIEW (self->view), FALSE);
-  gtd_task_list_view_set_task_list_selector_behavior (GTD_TASK_LIST_VIEW (self->view),
-                                                      GTD_TASK_LIST_SELECTOR_BEHAVIOR_ALWAYS_HIDE);
 
   gtk_widget_set_hexpand (GTK_WIDGET (self->view), TRUE);
   gtk_widget_set_vexpand (GTK_WIDGET (self->view), TRUE);